Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oh-colorpicker: Replace defaultColor option with an actual default color #2270

Merged
merged 2 commits into from Jan 14, 2024

Conversation

florian-h05
Copy link
Contributor

Remove the defaultColor option.
Instead use RGB(0,0,0) black as default color if the Item state holds no valid color, so that the color picker is accessible.

Remove the defaultColor option.
Instead use RGB(0,0,0) black as default color if the Item state holds no valid color, so that the color picker is accessible.

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
@florian-h05 florian-h05 marked this pull request as ready for review January 14, 2024 11:08
@florian-h05 florian-h05 requested a review from a team as a code owner January 14, 2024 11:08
Copy link

relativeci bot commented Jan 14, 2024

Job #1347: Bundle Size — 15.84MiB (+0.52%).

2b4aba6(current) vs b7270d2 main#1158(baseline)

Important

Bundle introduced 1 and removed 1 duplicate package – View changed duplicate packages

Warning

Bundle introduced 13 new packages: @jsep-plugin/regex, @jsep-plugin/arrow, @jsep-plugin/object and 10 more – View changed packages

Bundle metrics  Change 10 changes Regression 5 regressions Improvement 1 improvement
                 Current
Job #1347
     Baseline
Job #1158
Regression  Initial JS 1.9MiB(+13.82%) 1.67MiB
Regression  Initial CSS 609.81KiB(+0.15%) 608.89KiB
Change  Cache Invalidation 93.81% 93.95%
Change  Chunks 217(-0.91%) 219
Change  Assets 683(-0.87%) 689
Change  Modules 3036(+78.59%) 1700
Regression  Duplicate Modules 170(+88.89%) 90
Improvement  Duplicate Code 1.6%(-17.95%) 1.95%
Regression  Packages 152(+10.14%) 138
Regression  Duplicate Packages 16(+6.67%) 15
Bundle size by type  Change 3 changes Regression 3 regressions
                 Current
Job #1347
     Baseline
Job #1158
Regression  JS 9.31MiB (+0.6%) 9.25MiB
Regression  Other 4.75MiB (+0.53%) 4.73MiB
Regression  CSS 861.35KiB (+0.22%) 859.49KiB
Not changed  Fonts 526.1KiB 526.1KiB
Not changed  Media 295.6KiB 295.6KiB
Not changed  IMG 140.74KiB 140.74KiB
Not changed  HTML 1.23KiB 1.23KiB

View job #1347 reportView florian-h05:oh-colorpicker branch activity

@florian-h05 florian-h05 added enhancement New feature or request main ui Main UI labels Jan 14, 2024
@florian-h05 florian-h05 added this to the 4.2 milestone Jan 14, 2024
@stefan-hoehn
Copy link
Contributor

stefan-hoehn commented Jan 14, 2024

I agree with this approach as I think the default color is nothing really important and it makes the code simpler.

I have pulled the code and tested it and it works fine.
Code looks good to me.

Thanks, Florian, for fixing this as this was really a pain for me ;-)

@florian-h05 florian-h05 merged commit f912de5 into openhab:main Jan 14, 2024
6 checks passed
@florian-h05 florian-h05 deleted the oh-colorpicker branch January 14, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request main ui Main UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants