New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lazy load the developer dock #2294
Conversation
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Job #1385: Bundle Size — 15.92MiB (+0.59%).Warning Bundle contains 16 duplicate packages – View duplicate packages Bundle metrics
Bundle size by type
View job #1385 report View florian-h05:lazy-load-developer-... branch activity View project dashboard |
@ghys Lazy loading the developer dock/sidebar makes sense IMO as only admins can use it, and it saves us some initial JS. |
It's certainly increasingly needed when the developer dock adds more and more features. I think it's just this, bundle 13: compared to the initial JS (in purple), that's nice to have but not critical. But I'm fine with your proposal to create a new one :) |
According to the RelativeCI bot it is around 80 KiB, which sounds quite nice to me.
I haven’t considered that, thanks for the suggestion! I’ll change that. |
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Looking at the latest report, I’m not sure whether it is now in bundle 16 and if not, how to put it there. I am now using the same webpack chunk name as for the admin pages: |
Given the fact that the add-on store is using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So be it!
I'd strive in general to limit the chunk fragmentation as we have plenty already (100+ chunks), the more we can combine some which will not be in the initial JS but related, the better, IMO.
Regression from #2294. When the developer dock was opened the first time, the navbar was not center aligned due to a styling issue because of the lazy loading. This works-around this by setting (sub)title after component creation. Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
No description provided.