Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix UoM metadata not stored when Item created from link #2302

Merged
merged 3 commits into from Feb 5, 2024
Merged

Fix UoM metadata not stored when Item created from link #2302

merged 3 commits into from Feb 5, 2024

Conversation

florian-h05
Copy link
Contributor

Fixes #2299.

Also enhances the Item name validation when creating a new Item from the Items list.

@florian-h05
Fix UoM metadata not stored when Item created from link
c6d6faa 
Fixes openhab#2299.

Also enhances the Item name validation when creating a new Item from the Items list.

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
@florian-h05 florian-h05 requested a review from a team as a code owner February 4, 2024 15:05
@florian-h05
Fix lint
40fecd6 
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
@florian-h05 florian-h05 added bug Something isn't working main ui Main UI labels Feb 4, 2024
@florian-h05 florian-h05 added this to the 4.2 milestone Feb 4, 2024
@florian-h05
Update comments
76f7444 
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
@relativeci RelativeCI
Copy link

relativeci bot commented Feb 4, 2024

Job #1405: Bundle Size — 11MiB (~+0.01%).

76f7444(current) vs 1e1ef59 main#1399(baseline)

Warning

Bundle contains 19 duplicate packages – View duplicate packages

Bundle metrics  Change 2 changes Regression 1 regression
                 Current
Job #1405		      Baseline
Job #1399
Regression  Initial JS 1.84MiB(~+0.01%) 1.84MiB
No change  Initial CSS 607.73KiB 607.73KiB
Change  Cache Invalidation 17.5% 16.74%
No change  Chunks 220 220
No change  Assets 242 242
No change  Modules 3074 3074
No change  Duplicate Modules 159 159
No change  Duplicate Code 1.74% 1.74%
No change  Packages 150 150
No change  Duplicate Packages 18 18
Bundle size by type  Change 1 change Regression 1 regression
                 Current
Job #1405		      Baseline
Job #1399
Regression  JS 9.19MiB (~+0.01%) 9.19MiB
Not changed  CSS 888.86KiB 888.86KiB
Not changed  Fonts 526.1KiB 526.1KiB
Not changed  Media 295.6KiB 295.6KiB
Not changed  IMG 140.74KiB 140.74KiB
Not changed  HTML 1.24KiB 1.24KiB
Not changed  Other 871B 871B

View job #1405 report View florian-h05:link-create-item-uom... branch activity View project dashboard

stefan-hoehn
stefan-hoehn approved these changes Feb 5, 2024
View reviewed changes
Copy link
Contributor

@stefan-hoehn stefan-hoehn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went through it and see no issues. Note that I did not have the chance to actually test it.

@florian-h05 florian-h05 merged commit 93dce56 into openhab:main Feb 5, 2024
6 checks passed
@florian-h05 florian-h05 deleted the link-create-item-uom-bugs branch February 5, 2024 20:15
@boehan boehan mentioned this pull request Feb 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefan-hoehn stefan-hoehn stefan-hoehn approved these changes

Assignees
No one assigned
Labels
bug Something isn't working main ui Main UI
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

UoM Metadata is not added to an item when created from channel
2 participants
@florian-h05 @stefan-hoehn