Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

oh-block: Allow setting style properties #2305

Merged
merged 2 commits into from Feb 5, 2024
Merged

oh-block: Allow setting style properties #2305

merged 2 commits into from Feb 5, 2024

Conversation

florian-h05
Copy link
Contributor

Also evaluate widget expressions in the block title.

@florian-h05
oh-block: Allow setting style properties
21a2a29 
Also evaluate widget expressions in the block title.

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
@florian-h05 florian-h05 requested a review from a team as a code owner February 5, 2024 11:43
@florian-h05 florian-h05 added enhancement New feature or request main ui Main UI labels Feb 5, 2024
@florian-h05 florian-h05 added this to the 4.2 milestone Feb 5, 2024
@relativeci RelativeCI
Copy link

relativeci bot commented Feb 5, 2024 •
edited

Job #1409: Bundle Size — 11MiB (~-0.01%).

01d85dd(current) vs eacf1d7 main#1406(baseline)

Warning

Bundle contains 19 duplicate packages – View duplicate packages

Bundle metrics  Change 2 changes Improvement 1 improvement
                 Current
Job #1409		      Baseline
Job #1406
Improvement  Initial JS 1.84MiB(~-0.01%) 1.84MiB
No change  Initial CSS 607.73KiB 607.73KiB
Change  Cache Invalidation 16.74% 0%
No change  Chunks 220 220
No change  Assets 242 242
No change  Modules 3074 3074
No change  Duplicate Modules 159 159
No change  Duplicate Code 1.74% 1.74%
No change  Packages 150 150
No change  Duplicate Packages 18 18
Bundle size by type  Change 1 change Improvement 1 improvement
                 Current
Job #1409		      Baseline
Job #1406
Improvement  JS 9.19MiB (~-0.01%) 9.19MiB
Not changed  CSS 888.86KiB 888.86KiB
Not changed  Fonts 526.1KiB 526.1KiB
Not changed  Media 295.6KiB 295.6KiB
Not changed  IMG 140.74KiB 140.74KiB
Not changed  HTML 1.24KiB 1.24KiB
Not changed  Other 871B 871B

View job #1409 report View florian-h05:oh-block-style branch activity View project dashboard

@florian-h05
Improve style
01d85dd 
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
@florian-h05 florian-h05 merged commit f4c02a7 into openhab:main Feb 5, 2024
6 checks passed
@florian-h05 florian-h05 deleted the oh-block-style branch February 5, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request main ui Main UI
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@florian-h05