Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addon config page: Use dirty mixin & Add Ctrl-S shortcut #2314

Merged
merged 1 commit into from Feb 6, 2024
Merged

Addon config page: Use dirty mixin & Add Ctrl-S shortcut #2314

merged 1 commit into from Feb 6, 2024

Conversation

florian-h05
Copy link
Contributor

Check for unsaved changes before leave and add the Ctrl-S shortcut for save.

This makes it consistent with the service config page.

@florian-h05
Addon config page: Check for unsaved changes before leave & Add Ctrl-…
511268d 
…S shortcut for save

This makes it consistent with the service config page.

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
@florian-h05 florian-h05 requested a review from a team as a code owner February 6, 2024 19:53
@florian-h05 florian-h05 added enhancement New feature or request main ui Main UI bug Something isn't working and removed enhancement New feature or request labels Feb 6, 2024
@florian-h05 florian-h05 added this to the 4.2 milestone Feb 6, 2024
@relativeci RelativeCI
Copy link

relativeci bot commented Feb 6, 2024

Job #1426: Bundle Size — 11MiB (~+0.01%).

511268d(current) vs 93dce56 main#1413(baseline)

Warning

Bundle contains 19 duplicate packages – View duplicate packages

Bundle metrics  Change 2 changes Regression 1 regression
                 Current
Job #1426		      Baseline
Job #1413
Regression  Initial JS 1.84MiB(~+0.01%) 1.84MiB
No change  Initial CSS 607.73KiB 607.73KiB
Change  Cache Invalidation 16.98% 17.52%
No change  Chunks 220 220
No change  Assets 242 242
No change  Modules 3074 3074
No change  Duplicate Modules 159 159
No change  Duplicate Code 1.74% 1.74%
No change  Packages 150 150
No change  Duplicate Packages 18 18
Bundle size by type  Change 1 change Regression 1 regression
                 Current
Job #1426		      Baseline
Job #1413
Regression  JS 9.19MiB (~+0.01%) 9.19MiB
Not changed  CSS 888.86KiB 888.86KiB
Not changed  Fonts 526.1KiB 526.1KiB
Not changed  Media 295.6KiB 295.6KiB
Not changed  IMG 140.74KiB 140.74KiB
Not changed  HTML 1.24KiB 1.24KiB
Not changed  Other 871B 871B

View job #1426 report View florian-h05:addon-config-dirty-c... branch activity View project dashboard

@florian-h05 florian-h05 merged commit 1d5d217 into openhab:main Feb 6, 2024
6 checks passed
@florian-h05 florian-h05 deleted the addon-config-dirty-ctrl-s branch February 6, 2024 20:05
@florian-h05 florian-h05 mentioned this pull request Feb 17, 2024
Merged
florian-h05 added a commit that referenced this pull request Feb 17, 2024
@florian-h05
Add-on config page: Fix dirty handling (#2370)
644a1fc 
Fix regressions & leftovers from #2314.

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working main ui Main UI
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@florian-h05