Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[blockly] Add tooltips to the show block/code buttons #2317

Merged
merged 2 commits into from Feb 7, 2024
Merged

[blockly] Add tooltips to the show block/code buttons #2317

merged 2 commits into from Feb 7, 2024

Conversation

jimtng
Copy link
Contributor

@jimtng jimtng commented Feb 7, 2024

No description provided.

@jimtng jimtng requested a review from a team as a code owner February 7, 2024 04:20
@relativeci RelativeCI
Copy link

relativeci bot commented Feb 7, 2024 •
edited

Job #1459: Bundle Size — 11MiB (~+0.01%).

0591960(current) vs aa79ab2 main#1458(baseline)

Warning

Bundle contains 19 duplicate packages – View duplicate packages

Bundle metrics  no changes
                 Current
Job #1459		      Baseline
Job #1458
No change  Initial JS 1.84MiB 1.84MiB
No change  Initial CSS 607.73KiB 607.73KiB
No change  Cache Invalidation 16.97% 16.97%
No change  Chunks 220 220
No change  Assets 242 242
No change  Modules 3075 3075
No change  Duplicate Modules 159 159
No change  Duplicate Code 1.74% 1.74%
No change  Packages 150 150
No change  Duplicate Packages 18 18
Bundle size by type  Change 1 change Regression 1 regression
                 Current
Job #1459		      Baseline
Job #1458
Regression  JS 9.19MiB (~+0.01%) 9.19MiB
Not changed  CSS 888.86KiB 888.86KiB
Not changed  Fonts 526.1KiB 526.1KiB
Not changed  Media 295.6KiB 295.6KiB
Not changed  IMG 140.74KiB 140.74KiB
Not changed  HTML 1.24KiB 1.24KiB
Not changed  Other 871B 871B

View job #1459 report View jimtng:blockly-codeswitch-toolti... branch activity View project dashboard

@jimtng
[blockly] Add tooltips to the show block/code buttons
050c52b 
Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
@jimtng jimtng force-pushed the blockly-codeswitch-tooltips branch from 1cd0789 to 050c52b Compare February 7, 2024 10:58
florian-h05
florian-h05 reviewed Feb 7, 2024
View reviewed changes
Copy link
Contributor

@florian-h05 florian-h05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I’ve just left two comments to simplify the code.

bundles/org.openhab.ui/web/src/pages/settings/rules/script/script-edit.vue Outdated Show resolved Hide resolved
bundles/org.openhab.ui/web/src/pages/settings/rules/script/script-edit.vue Outdated Show resolved Hide resolved
@jimtng
Change :tooltip to tooltip
0591960 
Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
florian-h05
florian-h05 approved these changes Feb 7, 2024
View reviewed changes
Copy link
Contributor

@florian-h05 florian-h05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@florian-h05 florian-h05 added enhancement New feature or request main ui Main UI labels Feb 7, 2024
@florian-h05 florian-h05 added this to the 4.2 milestone Feb 7, 2024
@florian-h05 florian-h05 merged commit e18a057 into openhab:main Feb 7, 2024
6 checks passed
@jimtng jimtng deleted the blockly-codeswitch-tooltips branch February 7, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@florian-h05 florian-h05 florian-h05 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request main ui Main UI
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jimtng @florian-h05