Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model picker popup: Add "Show name" and "Show tags" options #2320

Merged
merged 1 commit into from Feb 9, 2024

Conversation

jimtng
Copy link
Contributor

@jimtng jimtng commented Feb 7, 2024

This makes it easier to find items e.g. when building rules

@jimtng jimtng requested a review from a team as a code owner February 7, 2024 10:52
Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
@jimtng jimtng force-pushed the model-picker-include-name-tags branch from e3316b0 to c0106d0 Compare February 7, 2024 10:52
Copy link

relativeci bot commented Feb 7, 2024

Job #1436: Bundle Size — 11MiB (+0.02%).

c0106d0(current) vs 1d5d217 main#1428(baseline)

Warning

Bundle contains 19 duplicate packages – View duplicate packages

Bundle metrics  Change 2 changes Regression 1 regression
                 Current
Job #1436
     Baseline
Job #1428
No change  Initial JS 1.84MiB 1.84MiB
No change  Initial CSS 607.73KiB 607.73KiB
Change  Cache Invalidation 18.37% 16.98%
No change  Chunks 220 220
No change  Assets 242 242
No change  Modules 3074 3074
No change  Duplicate Modules 159 159
Regression  Duplicate Code 1.75%(+0.57%) 1.74%
No change  Packages 150 150
No change  Duplicate Packages 18 18
Bundle size by type  Change 1 change Regression 1 regression
                 Current
Job #1436
     Baseline
Job #1428
Regression  JS 9.19MiB (+0.03%) 9.19MiB
Not changed  CSS 888.86KiB 888.86KiB
Not changed  Fonts 526.1KiB 526.1KiB
Not changed  Media 295.6KiB 295.6KiB
Not changed  IMG 140.74KiB 140.74KiB
Not changed  HTML 1.24KiB 1.24KiB
Not changed  Other 871B 871B

View job #1436 reportView jimtng:model-picker-include-name... branch activityView project dashboard

Copy link
Contributor

@florian-h05 florian-h05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

I am not very happy with the styling though, in the popup the styling issue IMO is more obvious than on the model page, but that is not related to your PR.

@florian-h05 florian-h05 added enhancement New feature or request main ui Main UI labels Feb 9, 2024
@florian-h05 florian-h05 added this to the 4.2 milestone Feb 9, 2024
@florian-h05 florian-h05 changed the title Add "Show name" and "Show tags" options to Model Picker Popup Model picker popup: Add "Show name" and "Show tags" options Feb 9, 2024
@florian-h05 florian-h05 merged commit 6f167a5 into openhab:main Feb 9, 2024
6 checks passed
@jimtng jimtng deleted the model-picker-include-name-tags branch February 10, 2024 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request main ui Main UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants