Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Item details: Fix group member selection allows to select unmanaged Items #2328

Merged
merged 1 commit into from Feb 9, 2024
Merged

Item details: Fix group member selection allows to select unmanaged Items #2328

merged 1 commit into from Feb 9, 2024

Conversation

florian-h05
Copy link
Contributor

This lead to an error being thrown because openHAB core does not allow to modify group membership of unmanaged Items and returns a 405.

@florian-h05
Item form: Fix direct group member selection allows to select unmanag…
86c49a0 
…ed Items

This lead to an error being thrown because openHAB core does not allow to modify group membership of unmanaged Items and returns a 405.

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
@florian-h05 florian-h05 requested a review from a team as a code owner February 9, 2024 18:08
@florian-h05 florian-h05 added bug Something isn't working main ui Main UI labels Feb 9, 2024
@florian-h05 florian-h05 added this to the 4.2 milestone Feb 9, 2024
@relativeci RelativeCI
Copy link

relativeci bot commented Feb 9, 2024

Job #1472: Bundle Size — 11MiB (~+0.01%).

86c49a0(current) vs 5e5261b main#1465(baseline)

Warning

Bundle contains 19 duplicate packages – View duplicate packages

Bundle metrics  Change 1 change
                 Current
Job #1472		      Baseline
Job #1465
No change  Initial JS 1.84MiB 1.84MiB
No change  Initial CSS 607.73KiB 607.73KiB
Change  Cache Invalidation 18.76% 17.03%
No change  Chunks 220 220
No change  Assets 242 242
No change  Modules 3075 3075
No change  Duplicate Modules 159 159
No change  Duplicate Code 1.74% 1.74%
No change  Packages 150 150
No change  Duplicate Packages 18 18
Bundle size by type  Change 1 change Regression 1 regression
                 Current
Job #1472		      Baseline
Job #1465
Regression  JS 9.19MiB (~+0.01%) 9.19MiB
Not changed  CSS 888.86KiB 888.86KiB
Not changed  Fonts 526.1KiB 526.1KiB
Not changed  Media 295.6KiB 295.6KiB
Not changed  IMG 140.74KiB 140.74KiB
Not changed  HTML 1.24KiB 1.24KiB
Not changed  Other 871B 871B

View job #1472 report View florian-h05:item-form-group-memb... branch activity View project dashboard

@florian-h05 florian-h05 changed the title Item form: Fix group member selection allows selection of unmanaged Items Item details: Fix group member selection allows selection of unmanaged Items Feb 9, 2024
@florian-h05 florian-h05 changed the title Item details: Fix group member selection allows selection of unmanaged Items Item details: Fix group member selection allows to select unmanaged Items Feb 9, 2024
@florian-h05
Copy link
Contributor Author

To reproduce this error, create a few Items by file, e.g.:

Switch test_switch
Number:Temperature test_temperature

Create a group from the UI or by file, then change direct group members and select test_switch and test_temperature. Apply this change by confirming the following dialogs and you will receiver an error.

stefan-hoehn
stefan-hoehn approved these changes Feb 9, 2024
View reviewed changes
Copy link
Contributor

@stefan-hoehn stefan-hoehn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

straight forward and clear. LGTM.

@florian-h05 florian-h05 merged commit 22a4b99 into openhab:main Feb 9, 2024
6 checks passed
@florian-h05 florian-h05 deleted the item-form-group-members branch February 9, 2024 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefan-hoehn stefan-hoehn stefan-hoehn approved these changes

Assignees
No one assigned
Labels
bug Something isn't working main ui Main UI
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@florian-h05 @stefan-hoehn