Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Settings page: Fix loading takes very long #2332

Merged
merged 1 commit into from Feb 9, 2024
Merged

Settings page: Fix loading takes very long #2332

merged 1 commit into from Feb 9, 2024

Conversation

florian-h05
Copy link
Contributor

Fixes #2323.

@florian-h05 florian-h05 requested a review from a team as a code owner February 9, 2024 22:51
@florian-h05 florian-h05 added bug Something isn't working main ui Main UI labels Feb 9, 2024
@florian-h05 florian-h05 added this to the 4.2 milestone Feb 9, 2024
@florian-h05
Settings page: Improve loading behaviour
5d63596 
Fixes openhab#2323.

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
@relativeci RelativeCI
Copy link

relativeci bot commented Feb 9, 2024

Job #1483: Bundle Size — 11.01MiB (~+0.01%).

5d63596(current) vs 98271e5 main#1482(baseline)

Warning

Bundle contains 19 duplicate packages – View duplicate packages

Bundle metrics  Change 1 change
                 Current
Job #1483		      Baseline
Job #1482
No change  Initial JS 1.84MiB 1.84MiB
No change  Initial CSS 607.73KiB 607.73KiB
Change  Cache Invalidation 16.97% 17.34%
No change  Chunks 220 220
No change  Assets 242 242
No change  Modules 3075 3075
No change  Duplicate Modules 159 159
No change  Duplicate Code 1.75% 1.75%
No change  Packages 150 150
No change  Duplicate Packages 18 18
Bundle size by type  Change 1 change Regression 1 regression
                 Current
Job #1483		      Baseline
Job #1482
Regression  JS 9.2MiB (~+0.01%) 9.2MiB
Not changed  CSS 888.86KiB 888.86KiB
Not changed  Fonts 526.1KiB 526.1KiB
Not changed  Media 295.6KiB 295.6KiB
Not changed  IMG 140.74KiB 140.74KiB
Not changed  HTML 1.24KiB 1.24KiB
Not changed  Other 871B 871B

View job #1483 report View florian-h05:settings-menu-loadin... branch activity View project dashboard

@florian-h05 florian-h05 merged commit 6ed621e into openhab:main Feb 9, 2024
6 checks passed
@florian-h05 florian-h05 deleted the settings-menu-loading branch February 9, 2024 23:21
@digitaldan
Copy link
Contributor

Thank you for fixing this ! Was driving me nuts !

@florian-h05
Copy link
Contributor Author

Yeah, that probably was one of the most annoying things in the UI.

@florian-h05 florian-h05 changed the title Settings page: Improve loading behaviour Settings page: Fix loading takes very long Feb 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working main ui Main UI
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

Settings page is slow to load
2 participants
@florian-h05 @digitaldan