Label and style all UID elements consistently

[jimtng]

Resolve #2335

Old Label	New Label	Note
ID	Page ID
ID	Widget ID
Unique ID	Rule ID
Unique ID	Transformation ID	This is for the last part of the Transformation ID
Unique ID	Transformation UID	This was labelled the same as above but hidden during creation.
Identifier	Thing ID
Channel Identifier	Channel ID	This is for the last part of the Channel UID

Create a new Thing

• Changed Unique ID => Thing ID
• To be consistent with Add Channel and Add Transformation, the full Thing UID is not shown when creating a new thing

View an existing Thing

• Changed Identifier => Thing UID
• The copy UID icon is moved to the end of the UID, to be consistent with all the other Copy UID icons

Add a new channel

• Changed Channel Identifier => Channel ID

Copy channel

View an existing channel

• Enable the copy UID icon even when the input is disabled

Add an Item

• Previously, a default item was pre-set to NewItem, making the placeholder not visible, and if the given default is erased, an error message is immediately displayed, so the placeholder is never visible either way.
• This PR changed so that no default is set for either the item name or the item label.
• The placeholder for the item name now indicates that it is a Unique ID for the item and that it cannot be changed afterwards.
• Previously a default label was set to 'New Item', making the label placeholder invisible.
• The label is now empty by default. This causes the placeholder to show which provides further hints about the Label vs the Item Name.

Edit/show an existing item

Create a new transformation

• Unique ID => Transformation ID (Only the last part of the transformation uid)

Show an existing transformation

• Unique ID => Transformation UID (The full UID)

Show Page ID

• ID => Page ID

Show existing Rule

• Unique ID => Rule ID

Add a new rule

• Unique ID => Rule ID

[relativeci]

Job #1589: Bundle Size — 11.01MiB (~+0.01%).

da0e865(current) vs 3f02477 main#1585(baseline)

Warning

Bundle contains 19 duplicate packages – View duplicate packages

Bundle metrics   1 change

	Current Job #1589	Baseline Job #1585
Initial JS	1.84MiB	1.84MiB
Initial CSS	607.89KiB	607.89KiB
Cache Invalidation	17.93%	23.24%
Chunks	220	220
Assets	242	242
Modules	3087	3087
Duplicate Modules	164	164
Duplicate Code	1.77%	1.77%
Packages	150	150
Duplicate Packages	18	18

Bundle size by type   1 change 1 regression

	Current Job #1589	Baseline Job #1585
JS	9.2MiB (~+0.01%)	9.2MiB
CSS	889.37KiB	889.37KiB
Fonts	526.1KiB	526.1KiB
Media	295.6KiB	295.6KiB
IMG	140.74KiB	140.74KiB
HTML	1.24KiB	1.24KiB
Other	871B	871B

---

View job #1589 report View jimtng:uniform-entity-id-labelli... branch activity View project dashboard

[mvalla]

For consistency also the doc page should be updated:

itemname -> itemid

https://www.openhab.org/docs/configuration/items.html

[jimtng]

For consistency also the doc page should be updated:

itemname -> itemid

I think this really needs a serious discussion from everyone. I feel that this change in terminology is going to be a fundamental change that everyone needs to be aware of and be on board with. @openhab/core-maintainers

The start of this discussion is here: https://community.openhab.org/t/item-editor/153739/23

[jimtng]

@mvalla I've updated the original post with more details + screenshots

[jimtng]

I'd like to hear your opinion too, @rkoshak

[wborn]

It is probably also part of REST/WebSocket APIs and code in core so if you want to be consistent those should also be updated. Those would be breaking API changes.

[mvalla]

It is probably also part of REST/WebSocket APIs and code in core so if you want to be consistent those should also be updated. Those would be breaking API changes.

Is it really necessary?
One thing is improve labels in the UI and correct the mess that is evident from the table in the first comment (basically every UI page uses a different way to label the object ID…)

Another thing is now refactor the API that has of course huge implications with all the apps…

[ghys]

Have you checked whether this "Transformation UID" label wouldn't be truncated on mobile devices?

[jimtng]

Have you checked whether this "Transformation UID" label wouldn't be truncated on mobile devices?

I made a transformation with a super long ID

This is how it looks like right now, before this PR. It got truncated.

With this PR, still truncated, but the copy icon is there

But yes, perhaps making it into a full line like before would give it that bit extra space. I'll push a change shortly.

[jimtng]

I've made transformation uid into a separate line just like channel uid. It's still not ideal/foolproof. Perhaps a separate PR to clean up the styling for all the potentially-long fields.

[florian-h05]

@jimtng Can you please resolve conflicts?

[jimtng]

I've made transformation uid into a separate line just like channel uid. It's still not ideal/foolproof. Perhaps a separate PR to clean up the styling for all the potentially-long fields.

What's the preferred method: merging main like what I just did here, or rebase and force push?

[florian-h05]

Rebase and force push.

[jimtng]

Rebase and force push.

Would you like me to do that now?

[florian-h05]

If we then get rid of the merge commit, yes, please.

[jimtng]

Rebased. There were some minor changes (removal of unnecessary changes) too.

[florian-h05]

LGTM, thanks.

Just two minor comments I will take care myself.
I will also align the placeholders and notes used across the UI.

[jimtng]

This was set to list-item instead of list-input because channel UIDs tend to be long

[florian-h05]

It now looks like this:
Desktop:

iPhone:

[florian-h05]

I think I will revert to the old look here, but keep the transformation UID the new way (those usually aren't too long).