Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sidebar search scene and script integration #2338

Merged
merged 1 commit into from Feb 11, 2024
Merged

Fix sidebar search scene and script integration #2338

merged 1 commit into from Feb 11, 2024

Conversation

JustinGeorgi
Copy link
Contributor

Fixes a few minor error with scripts and scene in the developer toolbar search function:

  1. Scenes and scripts could be pinned but not unpinned
  2. Scenes and scripts were not enumerated with the other types for determining existence of search results

@JustinGeorgi
Fix sidebar search scene and script integration
575d680 
Signed-off-by: Justin Georgi <justin.georgi@gmail.com>
@JustinGeorgi JustinGeorgi requested a review from a team as a code owner February 10, 2024 15:42
@relativeci RelativeCI
Copy link

relativeci bot commented Feb 10, 2024

Job #1490: Bundle Size — 11.01MiB (~+0.01%).

575d680(current) vs 6ed621e main#1484(baseline)

Warning

Bundle contains 19 duplicate packages – View duplicate packages

Bundle metrics  no changes
                 Current
Job #1490		      Baseline
Job #1484
No change  Initial JS 1.84MiB 1.84MiB
No change  Initial CSS 607.73KiB 607.73KiB
No change  Cache Invalidation 16.97% 16.97%
No change  Chunks 220 220
No change  Assets 242 242
No change  Modules 3075 3075
No change  Duplicate Modules 159 159
No change  Duplicate Code 1.75% 1.75%
No change  Packages 150 150
No change  Duplicate Packages 18 18
Bundle size by type  Change 1 change Regression 1 regression
                 Current
Job #1490		      Baseline
Job #1484
Regression  JS 9.2MiB (~+0.01%) 9.2MiB
Not changed  CSS 888.86KiB 888.86KiB
Not changed  Fonts 526.1KiB 526.1KiB
Not changed  Media 295.6KiB 295.6KiB
Not changed  IMG 140.74KiB 140.74KiB
Not changed  HTML 1.24KiB 1.24KiB
Not changed  Other 871B 871B

View job #1490 report View JustinGeorgi:jag-docktools-fix branch activity View project dashboard

florian-h05
florian-h05 approved these changes Feb 11, 2024
View reviewed changes
Copy link
Contributor

@florian-h05 florian-h05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@florian-h05 florian-h05 added bug Something isn't working main ui Main UI labels Feb 11, 2024
@florian-h05 florian-h05 added this to the 4.2 milestone Feb 11, 2024
@florian-h05 florian-h05 merged commit 7c78241 into openhab:main Feb 11, 2024
6 checks passed
@JustinGeorgi JustinGeorgi deleted the jag-docktools-fix branch February 11, 2024 15:40
@florian-h05 florian-h05 added the patch A PR that has been cherry-picked to a patch release branch label Feb 17, 2024
florian-h05 pushed a commit that referenced this pull request Feb 17, 2024
@JustinGeorgi @florian-h05
Fix sidebar search scene and script integration (#2338)
00a30dd 
Fixes a few minor error with scripts and scene in the developer toolbar
search function:
1) Scenes and scripts could be pinned but not unpinned
2) Scenes and scripts were not enumerated with the other types for
determining existence of search results

Signed-off-by: Justin Georgi <justin.georgi@gmail.com>
(cherry picked from commit 7c78241)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@florian-h05 florian-h05 florian-h05 approved these changes

Assignees
No one assigned
Labels
bug Something isn't working main ui Main UI patch A PR that has been cherry-picked to a patch release branch
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JustinGeorgi @florian-h05