Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes & Improvements to persistence edit, channel details & doc links logic #2339

Merged
merged 4 commits into from Feb 10, 2024
Merged

Fixes & Improvements to persistence edit, channel details & doc links logic #2339

merged 4 commits into from Feb 10, 2024

Conversation

florian-h05
Copy link
Contributor

  • Improve doc link logic and use Vuex store for the openHAB website url.
  • Channel info: Fix clear buttons displayed even if not editable.
  • Persistence edit: Fix styling issues.

@florian-h05
Improve doc links logic
87450e4 
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
@florian-h05
Fix channel info clear button displayed if not editable
976d03d 
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
@florian-h05
Persistence edit: Fix styling issues
abc2150 
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
@florian-h05 florian-h05 requested a review from a team as a code owner February 10, 2024 16:14
@florian-h05 florian-h05 added the main ui Main UI label Feb 10, 2024
@florian-h05 florian-h05 added this to the 4.2 milestone Feb 10, 2024
@florian-h05
Fix lint
a3e4887 
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
@relativeci RelativeCI
Copy link

relativeci bot commented Feb 10, 2024

Job #1494: Bundle Size — 11.01MiB (-0.01%).

a3e4887(current) vs 6ed621e main#1484(baseline)

Warning

Bundle contains 19 duplicate packages – View duplicate packages

Bundle metrics  Change 2 changes Regression 1 regression
                 Current
Job #1494		      Baseline
Job #1484
Regression  Initial JS 1.84MiB(~+0.01%) 1.84MiB
No change  Initial CSS 607.73KiB 607.73KiB
Change  Cache Invalidation 17.84% 16.97%
No change  Chunks 220 220
No change  Assets 242 242
No change  Modules 3075 3075
No change  Duplicate Modules 159 159
No change  Duplicate Code 1.75% 1.75%
No change  Packages 150 150
No change  Duplicate Packages 18 18
Bundle size by type  Change 2 changes Regression 1 regression Improvement 1 improvement
                 Current
Job #1494		      Baseline
Job #1484
Improvement  JS 9.2MiB (-0.01%) 9.2MiB
Regression  CSS 888.91KiB (~+0.01%) 888.86KiB
Not changed  Fonts 526.1KiB 526.1KiB
Not changed  Media 295.6KiB 295.6KiB
Not changed  IMG 140.74KiB 140.74KiB
Not changed  HTML 1.24KiB 1.24KiB
Not changed  Other 871B 871B

View job #1494 report View florian-h05:enhancements branch activity View project dashboard

@florian-h05 florian-h05 merged commit 75bac51 into openhab:main Feb 10, 2024
6 checks passed
@florian-h05 florian-h05 deleted the enhancements branch February 10, 2024 16:30
@jimtng jimtng mentioned this pull request Feb 13, 2024
Merged
florian-h05 pushed a commit that referenced this pull request Feb 13, 2024
@jimtng
Fix item-add save (#2346)
76aebaf 
Regression from #2339 causing a new item unable to be created / saved.

Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
@florian-h05 florian-h05 mentioned this pull request Feb 23, 2024
Merged
florian-h05 pushed a commit that referenced this pull request Feb 23, 2024
@jimtng
Fix link to persistence doc (#2398)
6927c7f 
Regression from #2339.

Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
@florian-h05 florian-h05 added the bug Something isn't working label Mar 2, 2024
seime pushed a commit to seime/openhab-webui that referenced this pull request Mar 16, 2024
@jimtng @seime
Fix link to persistence doc (openhab#2398)
fc8e6e4 
Regression from openhab#2339.

Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
Signed-off-by: Arne Seime <arne.seime@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working main ui Main UI
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@florian-h05