New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow custom page icons #2340
Allow custom page icons #2340
Conversation
Signed-off-by: Justin Georgi <justin.georgi@gmail.com>
Job #1491: Bundle Size — 11.01MiB (~+0.01%).Warning Bundle contains 19 duplicate packages – View duplicate packages Bundle metrics
Bundle size by type
View job #1491 report View JustinGeorgi:jag-page-icons branch activity View project dashboard |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
This will be a people-pleaser for sure! I'm asking because I attended a talk last weekend about that: |
@ghys Nothing complicated. I'm on the very less serious side of home brewers. I don't have a fermentation fridge so I use an OH page to track the temp in the room where my fermentation kettle is (and get an alert if it runs out of range) The same page keeps a quick record of what stage the batch is in and when I need to next to do something and a link to the recipe for reference. I admit, though, the iSpindle post a little while back caught my attention: That might be the hook that starts me on the slippery slope to full OH integration with my brews... |
Regression from openhab#2340. Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Regression from #2340. Reported on the community: https://community.openhab.org/t/openhab-4-2-milestone-discussion/154316/2?u=florian-h05. Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
This adds the ability to set custom icons for pages. The custom icons can be any icons available to the the oh-icon component. They are visible in the side bar and in the page settings list: