Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow custom page icons #2340

Merged
merged 1 commit into from Feb 11, 2024
Merged

Conversation

JustinGeorgi
Copy link
Contributor

This adds the ability to set custom icons for pages. The custom icons can be any icons available to the the oh-icon component. They are visible in the side bar and in the page settings list:
image

image

image

Signed-off-by: Justin Georgi <justin.georgi@gmail.com>
@JustinGeorgi JustinGeorgi requested a review from a team as a code owner February 10, 2024 16:14
Copy link

relativeci bot commented Feb 10, 2024

Job #1491: Bundle Size — 11.01MiB (~+0.01%).

b4025c4(current) vs 6ed621e main#1484(baseline)

Warning

Bundle contains 19 duplicate packages – View duplicate packages

Bundle metrics  Change 2 changes Regression 1 regression
                 Current
Job #1491
     Baseline
Job #1484
Regression  Initial JS 1.84MiB(~+0.01%) 1.84MiB
No change  Initial CSS 607.73KiB 607.73KiB
Change  Cache Invalidation 22.56% 16.97%
No change  Chunks 220 220
No change  Assets 242 242
No change  Modules 3075 3075
No change  Duplicate Modules 159 159
No change  Duplicate Code 1.75% 1.75%
No change  Packages 150 150
No change  Duplicate Packages 18 18
Bundle size by type  Change 1 change Regression 1 regression
                 Current
Job #1491
     Baseline
Job #1484
Regression  JS 9.2MiB (~+0.01%) 9.2MiB
Not changed  CSS 888.86KiB 888.86KiB
Not changed  Fonts 526.1KiB 526.1KiB
Not changed  Media 295.6KiB 295.6KiB
Not changed  IMG 140.74KiB 140.74KiB
Not changed  HTML 1.24KiB 1.24KiB
Not changed  Other 871B 871B

View job #1491 reportView JustinGeorgi:jag-page-icons branch activityView project dashboard

Copy link
Contributor

@florian-h05 florian-h05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@florian-h05 florian-h05 added this to the 4.2 milestone Feb 11, 2024
@florian-h05 florian-h05 added enhancement New feature or request main ui Main UI labels Feb 11, 2024
@florian-h05 florian-h05 merged commit 946b499 into openhab:main Feb 11, 2024
6 checks passed
@ghys
Copy link
Member

ghys commented Feb 11, 2024

This will be a people-pleaser for sure!
By the way, @JustinGeorgi, do you track your beer brewing with openHAB? (just assuming from your first screenshot)

I'm asking because I attended a talk last weekend about that:
https://fosdem.org/2024/schedule/event/fosdem-2024-2213-brewing-free-beer-with-esphome-and-home-assistant/
and an openHAB alternative would be most welcome :)

@JustinGeorgi
Copy link
Contributor Author

@ghys Nothing complicated. I'm on the very less serious side of home brewers. I don't have a fermentation fridge so I use an OH page to track the temp in the room where my fermentation kettle is (and get an alert if it runs out of range) The same page keeps a quick record of what stage the batch is in and when I need to next to do something and a link to the recipe for reference.

I admit, though, the iSpindle post a little while back caught my attention:
https://community.openhab.org/t/ispindle-track-your-homebrews-with-an-opensource-mqtt-hydrometer-temperature-sensor/151009

That might be the hook that starts me on the slippery slope to full OH integration with my brews...

@JustinGeorgi JustinGeorgi deleted the jag-page-icons branch February 11, 2024 15:40
florian-h05 added a commit to florian-h05/openhab-webui that referenced this pull request Mar 4, 2024
Regression from openhab#2340.

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
florian-h05 added a commit that referenced this pull request Mar 4, 2024
Regression from #2340.

Reported on the community:
https://community.openhab.org/t/openhab-4-2-milestone-discussion/154316/2?u=florian-h05.

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request main ui Main UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants