Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove padding in list grouping toolbar #2347

Merged
merged 2 commits into from Feb 14, 2024
Merged

Remove padding in list grouping toolbar #2347

merged 2 commits into from Feb 14, 2024

Conversation

jimtng
Copy link
Contributor

@jimtng jimtng commented Feb 13, 2024

A minor cosmetic change

Before:
image

After:
image

@jimtng
Remove padding in list grouping toolbar
b03ccf2 
Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
@jimtng jimtng requested a review from a team as a code owner February 13, 2024 07:59
@relativeci RelativeCI
Copy link

relativeci bot commented Feb 13, 2024 •
edited

Job #1519: Bundle Size — 11.01MiB (~+0.01%).

63237d3(current) vs 76aebaf main#1509(baseline)

Warning

Bundle contains 19 duplicate packages – View duplicate packages

Bundle metrics  Change 3 changes Improvement 1 improvement
                 Current
Job #1519		      Baseline
Job #1509
Improvement  Initial JS 1.84MiB(~-0.01%) 1.84MiB
No change  Initial CSS 607.73KiB 607.73KiB
Change  Cache Invalidation 17.53% 17.34%
No change  Chunks 220 220
No change  Assets 242 242
Change  Modules 3078(+0.1%) 3075
No change  Duplicate Modules 159 159
No change  Duplicate Code 1.75% 1.75%
No change  Packages 150 150
No change  Duplicate Packages 18 18
Bundle size by type  Change 2 changes Regression 1 regression Improvement 1 improvement
                 Current
Job #1519		      Baseline
Job #1509
Improvement  JS 9.2MiB (~-0.01%) 9.2MiB
Regression  CSS 889.1KiB (+0.02%) 888.91KiB
Not changed  Fonts 526.1KiB 526.1KiB
Not changed  Media 295.6KiB 295.6KiB
Not changed  IMG 140.74KiB 140.74KiB
Not changed  HTML 1.24KiB 1.24KiB
Not changed  Other 871B 871B

View job #1519 report View jimtng:remove-list-group-toolbar... branch activity View project dashboard

@ghys
Copy link
Member

ghys commented Feb 13, 2024

These were added on purpose to avoid them touching the edge of the screen on mobiles:
Screen Shot 2024-02-13 at 18 17 50

@jimtng
Copy link
Contributor Author

jimtng commented Feb 13, 2024 •
edited

These were added on purpose to avoid them touching the edge of the screen on mobiles:

Would adding a @media condition be an acceptable solution?

@jimtng
Only remove padding on wider screens
63237d3 
Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
@jimtng jimtng force-pushed the remove-list-group-toolbar-padding branch from 34dcbf0 to 63237d3 Compare February 13, 2024 17:53
florian-h05
florian-h05 approved these changes Feb 14, 2024
View reviewed changes
Copy link
Contributor

@florian-h05 florian-h05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@florian-h05 florian-h05 merged commit e2d2ca6 into openhab:main Feb 14, 2024
6 checks passed
@florian-h05 florian-h05 added enhancement New feature or request main ui Main UI labels Feb 14, 2024
@florian-h05 florian-h05 added this to the 4.2 milestone Feb 14, 2024
@jimtng jimtng deleted the remove-list-group-toolbar-padding branch February 15, 2024 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@florian-h05 florian-h05 florian-h05 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request main ui Main UI
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jimtng @ghys @florian-h05