Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept double click to pick an Item in model picker popup #2348

Merged
merged 2 commits into from Feb 15, 2024

Conversation

jimtng
Copy link
Contributor

@jimtng jimtng commented Feb 13, 2024

Allow double clicking to select an item here, without having to click "Pick" at the top right corner

image

@jimtng jimtng requested a review from a team as a code owner February 13, 2024 09:36
Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
Copy link

relativeci bot commented Feb 13, 2024

Job #1527: Bundle Size — 11.01MiB (~+0.01%).

444c6b2(current) vs e2d2ca6 main#1526(baseline)

Warning

Bundle contains 19 duplicate packages – View duplicate packages

Bundle metrics  Change 1 change
                 Current
Job #1527
     Baseline
Job #1526
No change  Initial JS 1.84MiB 1.84MiB
No change  Initial CSS 607.73KiB 607.73KiB
Change  Cache Invalidation 18.36% 17.52%
No change  Chunks 220 220
No change  Assets 242 242
No change  Modules 3078 3078
No change  Duplicate Modules 159 159
No change  Duplicate Code 1.75% 1.75%
No change  Packages 150 150
No change  Duplicate Packages 18 18
Bundle size by type  Change 1 change Regression 1 regression
                 Current
Job #1527
     Baseline
Job #1526
Regression  JS 9.2MiB (~+0.01%) 9.2MiB
Not changed  CSS 889.1KiB 889.1KiB
Not changed  Fonts 526.1KiB 526.1KiB
Not changed  Media 295.6KiB 295.6KiB
Not changed  IMG 140.74KiB 140.74KiB
Not changed  HTML 1.24KiB 1.24KiB
Not changed  Other 871B 871B

View job #1527 reportView jimtng:dblclick-model-picker-pop... branch activityView project dashboard

Copy link
Contributor

@florian-h05 florian-h05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general LGTM, however I wonder if we should check that the clicked Item is the same one.

Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
@jimtng
Copy link
Contributor Author

jimtng commented Feb 15, 2024

I wonder if we should check that the clicked Item is the same one.

I've added this check

Copy link
Contributor

@florian-h05 florian-h05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@florian-h05 florian-h05 added enhancement New feature or request main ui Main UI labels Feb 15, 2024
@florian-h05 florian-h05 added this to the 4.2 milestone Feb 15, 2024
@florian-h05 florian-h05 merged commit 735bf98 into openhab:main Feb 15, 2024
6 checks passed
@florian-h05 florian-h05 changed the title Accept double click to pick a model in model picker popup Accept double click to pick an Item in model picker popup Feb 15, 2024
@jimtng jimtng deleted the dblclick-model-picker-popup branch February 15, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request main ui Main UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants