Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rule edit: Fix undefined currentSection error in trigger-module-wizard #2350

Merged
merged 1 commit into from Feb 14, 2024
Merged

Rule edit: Fix undefined currentSection error in trigger-module-wizard #2350

merged 1 commit into from Feb 14, 2024

Conversation

jimtng
Copy link
Contributor

@jimtng jimtng commented Feb 13, 2024

No description provided.

@jimtng
Fix undefined currentSection error in trigger-module-wizard
e4b3d65 
Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
@jimtng jimtng requested a review from a team as a code owner February 13, 2024 10:15
@relativeci RelativeCI
Copy link

relativeci bot commented Feb 13, 2024

Job #1513: Bundle Size — 11.01MiB (~-0.01%).

e4b3d65(current) vs 76aebaf main#1509(baseline)

Warning

Bundle contains 19 duplicate packages – View duplicate packages

Bundle metrics  Change 1 change
                 Current
Job #1513		      Baseline
Job #1509
No change  Initial JS 1.84MiB 1.84MiB
No change  Initial CSS 607.73KiB 607.73KiB
Change  Cache Invalidation 16.97% 17.34%
No change  Chunks 220 220
No change  Assets 242 242
No change  Modules 3075 3075
No change  Duplicate Modules 159 159
No change  Duplicate Code 1.75% 1.75%
No change  Packages 150 150
No change  Duplicate Packages 18 18
Bundle size by type  Change 1 change Improvement 1 improvement
                 Current
Job #1513		      Baseline
Job #1509
Improvement  JS 9.2MiB (~-0.01%) 9.2MiB
Not changed  CSS 888.91KiB 888.91KiB
Not changed  Fonts 526.1KiB 526.1KiB
Not changed  Media 295.6KiB 295.6KiB
Not changed  IMG 140.74KiB 140.74KiB
Not changed  HTML 1.24KiB 1.24KiB
Not changed  Other 871B 871B

View job #1513 report View jimtng:trigger-module-remove-cur... branch activity View project dashboard

florian-h05
florian-h05 approved these changes Feb 14, 2024
View reviewed changes
Copy link
Contributor

@florian-h05 florian-h05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@florian-h05 florian-h05 added bug Something isn't working main ui Main UI labels Feb 14, 2024
@florian-h05 florian-h05 added this to the 4.2 milestone Feb 14, 2024
@florian-h05 florian-h05 changed the title Fix undefined currentSection error in trigger-module-wizard Rule edit: Fix undefined currentSection error in trigger-module-wizard Feb 14, 2024
@florian-h05 florian-h05 merged commit 85f21bb into openhab:main Feb 14, 2024
6 checks passed
@jimtng jimtng deleted the trigger-module-remove-currentsection branch February 15, 2024 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@florian-h05 florian-h05 florian-h05 approved these changes

Assignees
No one assigned
Labels
bug Something isn't working main ui Main UI
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jimtng @florian-h05