Rule edit: Remove redundant module title prefix #2352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Job #1518: Bundle Size — 11.01MiB (~+0.01%).Warning Bundle contains 19 duplicate packages – View duplicate packages Bundle metrics
Bundle size by type
View job #1518 report View jimtng:lowercase-module-descript... branch activity View project dashboard |
|
I like this! I never noticed how jarring it was before with the different cases in the triggers and the scripts. Have you checked the conditions too? 
I think removing the "If" same as you've removed the "When" from the triggers is warranted. |
jimtng
force-pushed
the
lowercase-module-description
branch
2 times, most recently
from
ee05291
to
dfbc40c
Compare
|
I've updated the screenshots |
jimtng
force-pushed
the
lowercase-module-description
branch
from
dfbc40c
to
9287764
Compare
ghys
requested changes
Feb 13, 2024
| case 'timer.GenericCronTrigger': | ||
| if (!config.cronExpression) return moduleType.label | ||
| try { | ||
| return cronstrue.toString(config.cronExpression, { | ||
| use24HourTimeFormat: true | ||
| }) | ||
| }).toLowerCase() |
There was a problem hiding this comment.
This won't work well with labels like "At 08:00, only on Monday and Thursday".
Just lowercase the first character.
There was a problem hiding this comment.
Sorry I force pushed - habit. But it's now only lowercasing the first letter.
Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
jimtng
force-pushed
the
lowercase-module-description
branch
from
9287764
to
60107f4
Compare
florian-h05
approved these changes
Feb 14, 2024
florian-h05
changed the title
florian-h05
pushed a commit
that referenced
this pull request
Feb 16, 2024
Fix regression from #2352. Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See openhab/openhab-core#4090
Before:
After:
