Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix alexa thermostat attribute parameters #2364

Merged
merged 1 commit into from Feb 16, 2024
Merged

Fix alexa thermostat attribute parameters #2364

merged 1 commit into from Feb 16, 2024

Conversation

jsetton
Copy link
Contributor

@jsetton jsetton commented Feb 16, 2024

Breakage introduced by #2194

@jsetton
Fix alexa thermostat attribute parameters
3b85678 
Signed-off-by: jsetton <jeremy.setton@gmail.com>
@jsetton jsetton requested a review from a team as a code owner February 16, 2024 19:43
@relativeci RelativeCI
Copy link

relativeci bot commented Feb 16, 2024

Job #1553: Bundle Size — 11.01MiB (~-0.01%).

3b85678(current) vs 02317ea main#1551(baseline)

Warning

Bundle contains 19 duplicate packages – View duplicate packages

Bundle metrics  Change 1 change
                 Current
Job #1553		      Baseline
Job #1551
No change  Initial JS 1.84MiB 1.84MiB
No change  Initial CSS 607.73KiB 607.73KiB
Change  Cache Invalidation 17.34% 16.96%
No change  Chunks 220 220
No change  Assets 242 242
No change  Modules 3078 3078
No change  Duplicate Modules 159 159
No change  Duplicate Code 1.75% 1.75%
No change  Packages 150 150
No change  Duplicate Packages 18 18
Bundle size by type  Change 1 change Improvement 1 improvement
                 Current
Job #1553		      Baseline
Job #1551
Improvement  JS 9.2MiB (~-0.01%) 9.2MiB
Not changed  CSS 889.3KiB 889.3KiB
Not changed  Fonts 526.1KiB 526.1KiB
Not changed  Media 295.6KiB 295.6KiB
Not changed  IMG 140.74KiB 140.74KiB
Not changed  HTML 1.24KiB 1.24KiB
Not changed  Other 871B 871B

View job #1553 report View jsetton:alexa-thermostat-attrs-f... branch activity View project dashboard

@florian-h05 florian-h05 merged commit 344779a into openhab:main Feb 16, 2024
6 checks passed
@florian-h05 florian-h05 added bug Something isn't working main ui Main UI labels Feb 16, 2024
@florian-h05 florian-h05 added this to the 4.2 milestone Feb 16, 2024
@florian-h05
Copy link
Contributor

Should this be backported to 4.1.x?

@jsetton
Copy link
Contributor Author

jsetton commented Feb 16, 2024

If there are plans to have a patch release, yes.

@jsetton jsetton mentioned this pull request Feb 16, 2024
Closed
@jsetton jsetton deleted the alexa-thermostat-attrs-fix branch February 16, 2024 22:10
florian-h05 pushed a commit that referenced this pull request Feb 17, 2024
@jsetton @florian-h05
Fix alexa thermostat attribute parameters (#2364)
974a864 
Breakage introduced by #2194

Signed-off-by: jsetton <jeremy.setton@gmail.com>
(cherry picked from commit 344779a)
@florian-h05
Copy link
Contributor

Cherry-picked to 4.1.x.

@florian-h05 florian-h05 added the patch A PR that has been cherry-picked to a patch release branch label Feb 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@florian-h05 florian-h05 florian-h05 approved these changes

Assignees
No one assigned
Labels
bug Something isn't working main ui Main UI patch A PR that has been cherry-picked to a patch release branch
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jsetton @florian-h05