Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a global component developer-dock-icon #2369

Merged
merged 3 commits into from Feb 18, 2024

Conversation

jimtng
Copy link
Contributor

@jimtng jimtng commented Feb 17, 2024

Also add the icon to widget-list and script-edit pages.

Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
@jimtng jimtng requested a review from a team as a code owner February 17, 2024 17:07
Copy link

relativeci bot commented Feb 17, 2024

Job #1581: Bundle Size — 11.01MiB (-0.03%).

c4bdce0(current) vs 26673dc main#1574(baseline)

Warning

Bundle contains 19 duplicate packages – View duplicate packages

Bundle metrics  Change 3 changes Regression 1 regression
                 Current
Job #1581
     Baseline
Job #1574
Regression  Initial JS 1.84MiB(+0.03%) 1.84MiB
No change  Initial CSS 607.73KiB 607.73KiB
Change  Cache Invalidation 18.14% 16.97%
No change  Chunks 220 220
No change  Assets 242 242
Change  Modules 3087(+0.1%) 3084
No change  Duplicate Modules 164 164
No change  Duplicate Code 1.77% 1.77%
No change  Packages 150 150
No change  Duplicate Packages 18 18
Bundle size by type  Change 1 change Improvement 1 improvement
                 Current
Job #1581
     Baseline
Job #1574
Improvement  JS 9.2MiB (-0.03%) 9.2MiB
Not changed  CSS 889.37KiB 889.37KiB
Not changed  Fonts 526.1KiB 526.1KiB
Not changed  Media 295.6KiB 295.6KiB
Not changed  IMG 140.74KiB 140.74KiB
Not changed  HTML 1.24KiB 1.24KiB
Not changed  Other 871B 871B

View job #1581 reportView jimtng:rules-help-icon branch activityView project dashboard

Copy link
Contributor

@florian-h05 florian-h05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice refactoring, thanks!

I've reformatted your code a bit, removed the icon from rule edit and added it to the widgets list.

@florian-h05 florian-h05 added the main ui Main UI label Feb 17, 2024
@florian-h05 florian-h05 added this to the 4.2 milestone Feb 17, 2024
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
@florian-h05 florian-h05 merged commit af6174b into openhab:main Feb 18, 2024
6 checks passed
@jimtng jimtng deleted the rules-help-icon branch February 18, 2024 11:12
@florian-h05
Copy link
Contributor

@jimtng One thing I now have noticed with the developer dock icon being on non-admin pages: It need to be hidden if the user is not logged in as admin.

Can you please fix that?

See

<f7-link v-if="(this.$store.getters.isAdmin && $store.state.developerDock && $f7.width >= 1280)" icon-f7="question_circle_fill" @click="$f7.emit('toggleDeveloperDock')" />
for reference how to check for admin, and BTW it seems you forgot to use the new component there.

florian-h05 pushed a commit that referenced this pull request Feb 19, 2024
Fix #2369 (comment).

Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
@florian-h05 florian-h05 added the enhancement New feature or request label Mar 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request main ui Main UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants