-
-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a global component developer-dock-icon #2369
Conversation
Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
Job #1581: Bundle Size — 11.01MiB (-0.03%).Warning Bundle contains 19 duplicate packages – View duplicate packages Bundle metrics
Bundle size by type
View job #1581 report View jimtng:rules-help-icon branch activity View project dashboard |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice refactoring, thanks!
I've reformatted your code a bit, removed the icon from rule edit and added it to the widgets list.
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
954ac95
to
c4bdce0
Compare
@jimtng One thing I now have noticed with the developer dock icon being on non-admin pages: It need to be hidden if the user is not logged in as admin. Can you please fix that? See
|
Fix #2369 (comment). Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
Also add the icon to widget-list and script-edit pages.