Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Item edit: Fix code tab not working properly #2375

Merged
merged 1 commit into from
Feb 18, 2024
Merged

Item edit: Fix code tab not working properly #2375

merged 1 commit into from
Feb 18, 2024

Conversation

florian-h05
Copy link
Contributor

This was due to bad ready handling, where the code editor was initialized with not editable because the Item was not loaded yet.

@florian-h05
Item edit: Fix code tab not working properly
d38e779 
This was due to bad ready handling, where the code editor was initialized with not editable because the Item was not loaded yet.

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
@florian-h05 florian-h05 requested a review from a team as a code owner February 18, 2024 15:49
@florian-h05 florian-h05 added bug Something isn't working enhancement New feature or request main ui Main UI and removed enhancement New feature or request labels Feb 18, 2024
@florian-h05 florian-h05 added this to the 4.2 milestone Feb 18, 2024
@relativeci RelativeCI
Copy link

relativeci bot commented Feb 18, 2024

Job #1592: Bundle Size — 11.01MiB (~-0.01%).

d38e779(current) vs a5869f3 main#1590(baseline)

Warning

Bundle contains 19 duplicate packages – View duplicate packages

Bundle metrics  Change 1 change
                 Current
Job #1592		      Baseline
Job #1590
No change  Initial JS 1.84MiB 1.84MiB
No change  Initial CSS 607.89KiB 607.89KiB
Change  Cache Invalidation 17.34% 17.93%
No change  Chunks 220 220
No change  Assets 242 242
No change  Modules 3087 3087
No change  Duplicate Modules 164 164
No change  Duplicate Code 1.77% 1.77%
No change  Packages 150 150
No change  Duplicate Packages 18 18
Bundle size by type  Change 1 change Improvement 1 improvement
                 Current
Job #1592		      Baseline
Job #1590
Improvement  JS 9.2MiB (~-0.01%) 9.2MiB
Not changed  CSS 889.37KiB 889.37KiB
Not changed  Fonts 526.1KiB 526.1KiB
Not changed  Media 295.6KiB 295.6KiB
Not changed  IMG 140.74KiB 140.74KiB
Not changed  HTML 1.24KiB 1.24KiB
Not changed  Other 871B 871B

View job #1592 report View florian-h05:item-edit-ready branch activity View project dashboard

@florian-h05 florian-h05 merged commit 260389b into openhab:main Feb 18, 2024
6 checks passed
@florian-h05 florian-h05 deleted the item-edit-ready branch February 22, 2024 20:42
@florian-h05 florian-h05 mentioned this pull request Apr 7, 2024
Merged
kaikreuzer pushed a commit that referenced this pull request Apr 7, 2024
@florian-h05
Thing details: Fix code tab not editable (#2526)
4a0054a 
Fixes #2523.

Regression from one of the previous PRs to the Thing details page.

This is a timing issue similar to #2375, where the code editor is
initialized as read-only because the Thing is not loaded yet.
After initialisation, the editor can not be set to read-write.

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working main ui Main UI
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@florian-h05