Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Persistence edit: Change empty-state-placeholder icon #2391

Merged
merged 1 commit into from Feb 22, 2024
Merged

Persistence edit: Change empty-state-placeholder icon #2391

merged 1 commit into from Feb 22, 2024

Conversation

mherwege
Copy link
Contributor

Change the icon shown when no persistence is configured to be the same as the icon on the settings page.

@mherwege
persistence icon
9523d55 
Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
@mherwege mherwege requested a review from a team as a code owner February 22, 2024 15:03
@relativeci RelativeCI
Copy link

relativeci bot commented Feb 22, 2024

Job #1624: Bundle Size — 11.01MiB (~+0.01%).

9523d55(current) vs ff034d5 main#1608(baseline)

Warning

Bundle contains 19 duplicate packages – View duplicate packages

Bundle metrics  Change 2 changes Regression 1 regression
                 Current
Job #1624		      Baseline
Job #1608
Regression  Initial JS 1.84MiB(~+0.01%) 1.84MiB
No change  Initial CSS 607.89KiB 607.89KiB
Change  Cache Invalidation 17.33% 23.25%
No change  Chunks 220 220
No change  Assets 242 242
No change  Modules 3087 3087
No change  Duplicate Modules 164 164
No change  Duplicate Code 1.77% 1.77%
No change  Packages 150 150
No change  Duplicate Packages 18 18
Bundle size by type  Change 1 change Regression 1 regression
                 Current
Job #1624		      Baseline
Job #1608
Regression  JS 9.2MiB (~+0.01%) 9.2MiB
Not changed  CSS 889.37KiB 889.37KiB
Not changed  Fonts 526.1KiB 526.1KiB
Not changed  Media 295.6KiB 295.6KiB
Not changed  IMG 140.74KiB 140.74KiB
Not changed  HTML 1.24KiB 1.24KiB
Not changed  Other 871B 871B

View job #1624 report View mherwege:persistence_icon branch activity View project dashboard

florian-h05
florian-h05 approved these changes Feb 22, 2024
View reviewed changes
Copy link
Contributor

@florian-h05 florian-h05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@florian-h05 florian-h05 changed the title Persistence configuration icon Persistence edit: Change empty-state-placeholder icon Feb 22, 2024
@florian-h05 florian-h05 added enhancement New feature or request main ui Main UI labels Feb 22, 2024
@florian-h05 florian-h05 added this to the 4.2 milestone Feb 22, 2024
@florian-h05 florian-h05 merged commit 3a93123 into openhab:main Feb 22, 2024
6 checks passed
@mherwege mherwege deleted the persistence_icon branch February 22, 2024 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@florian-h05 florian-h05 florian-h05 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request main ui Main UI
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mherwege @florian-h05