Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only align smart-select on wider screens #2405

Merged
merged 1 commit into from Feb 24, 2024
Merged

Only align smart-select on wider screens #2405

merged 1 commit into from Feb 24, 2024

Conversation

jimtng
Copy link
Contributor

@jimtng jimtng commented Feb 24, 2024

On smaller screens, it's better to stick with standard styling

@jimtng
Only align smart-select on wider screens
b482cbc 
Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
@jimtng jimtng requested a review from a team as a code owner February 24, 2024 08:57
@relativeci RelativeCI
Copy link

relativeci bot commented Feb 24, 2024

Job #1660: Bundle Size — 11.01MiB (~+0.01%).

b482cbc(current) vs 9cacb7c main#1659(baseline)

Warning

Bundle contains 19 duplicate packages – View duplicate packages

Bundle metrics  Change 2 changes Regression 1 regression
                 Current
Job #1660		      Baseline
Job #1659
No change  Initial JS 1.85MiB 1.85MiB
Regression  Initial CSS 607.92KiB(~+0.01%) 607.89KiB
Change  Cache Invalidation 5.39% 17%
No change  Chunks 220 220
No change  Assets 242 242
No change  Modules 3088 3088
No change  Duplicate Modules 164 164
No change  Duplicate Code 1.77% 1.77%
No change  Packages 150 150
No change  Duplicate Packages 18 18
Bundle size by type  Change 1 change Regression 1 regression
                 Current
Job #1660		      Baseline
Job #1659
Not changed  JS 9.2MiB 9.2MiB
Regression  CSS 889.47KiB (~+0.01%) 889.44KiB
Not changed  Fonts 526.1KiB 526.1KiB
Not changed  Media 295.6KiB 295.6KiB
Not changed  IMG 140.74KiB 140.74KiB
Not changed  HTML 1.24KiB 1.24KiB
Not changed  Other 871B 871B

View job #1660 report View jimtng:aligned-smart-select-larg... branch activity View project dashboard

florian-h05
florian-h05 approved these changes Feb 24, 2024
View reviewed changes
Copy link
Contributor

@florian-h05 florian-h05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks!

@florian-h05 florian-h05 added enhancement New feature or request main ui Main UI labels Feb 24, 2024
@florian-h05 florian-h05 added this to the 4.2 milestone Feb 24, 2024
@florian-h05 florian-h05 merged commit 6272434 into openhab:main Feb 24, 2024
6 checks passed
@jimtng jimtng deleted the aligned-smart-select-large-screen branch February 24, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@florian-h05 florian-h05 florian-h05 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request main ui Main UI
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jimtng @florian-h05