Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add-on store: Title and searchbar focus tweaks #2406

Merged
merged 8 commits into from Feb 28, 2024
Merged

Add-on store: Title and searchbar focus tweaks #2406

merged 8 commits into from Feb 28, 2024

Conversation

jimtng
Copy link
Contributor

@jimtng jimtng commented Feb 24, 2024 •
edited

  • Display specific title for each tab, but avoid becoming too long on smaller screens
  • Don't autofocus on the search bar on mobile because it opens up the on-screen keyboard and covers up half the screen
    - Add tooltip to the bottom tabbar on narrow screens

@jimtng jimtng requested a review from a team as a code owner February 24, 2024 11:21
@jimtng jimtng marked this pull request as draft February 24, 2024 11:42
@relativeci RelativeCI
Copy link

relativeci bot commented Feb 24, 2024 •
edited

Job #1711: Bundle Size — 11.01MiB (~-0.01%).

c38c49f(current) vs 4cef66d main#1710(baseline)

Warning

Bundle contains 19 duplicate packages – View duplicate packages

Bundle metrics  Change 1 change
                 Current
Job #1711		      Baseline
Job #1710
No change  Initial JS 1.85MiB 1.85MiB
No change  Initial CSS 607.92KiB 607.92KiB
Change  Cache Invalidation 17% 17.35%
No change  Chunks 220 220
No change  Assets 242 242
No change  Modules 3089 3089
No change  Duplicate Modules 164 164
No change  Duplicate Code 1.77% 1.77%
No change  Packages 150 150
No change  Duplicate Packages 18 18
Bundle size by type  Change 1 change Improvement 1 improvement
                 Current
Job #1711		      Baseline
Job #1710
Improvement  JS 9.2MiB (~-0.01%) 9.2MiB
Not changed  CSS 889.4KiB 889.4KiB
Not changed  Fonts 526.1KiB 526.1KiB
Not changed  Media 295.6KiB 295.6KiB
Not changed  IMG 140.74KiB 140.74KiB
Not changed  HTML 1.24KiB 1.24KiB
Not changed  Other 871B 871B

View job #1711 report View jimtng:addons-store branch activity View project dashboard

@jimtng
Only autofocus on searchbar on desktops
fc48802 
Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
@jimtng
Add tooltip to the bottom tabbar
e841264 
Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
@jimtng
Fix addons store title for wide screens
203df6a 
Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
@jimtng
Refactor labels
1dea3dc 
Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
@jimtng
Use shorter large titles
ed07a53 
Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
@jimtng jimtng marked this pull request as ready for review February 24, 2024 15:45
@florian-h05
Copy link
Contributor

Add tooltip to the bottom tabbar on narrow screens

I don't think this is a good idea, as having tooltips on clickable links is usually not working very well with touch devices.

@jimtng
Revert "Add tooltip to the bottom tabbar"
cba5f0e 
This reverts commit e841264.

Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
@jimtng
Copy link
Contributor Author

jimtng commented Feb 24, 2024

Add tooltip to the bottom tabbar on narrow screens

I don't think this is a good idea, as having tooltips on clickable links is usually not working very well with touch devices.

Reverted.

@jimtng
Use tab titles for large title
ea09b4b 
Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
@jimtng
Copy link
Contributor Author

jimtng commented Feb 26, 2024

Add tooltip to the bottom tabbar on narrow screens

I don't think this is a good idea, as having tooltips on clickable links is usually not working very well with touch devices.

BTW, the little buttons on the bottom of the blockly editor screen also have tooltips.

@florian-h05
Copy link
Contributor

BTW, the little buttons on the bottom of the blockly editor screen also have tooltips.

Yes, but these buttons are also displayed on desktop, where the tooltip is usable. The toolbar of the store is only displayed on mobile, where it is not really usable.

florian-h05
florian-h05 approved these changes Feb 28, 2024
View reviewed changes
Copy link
Contributor

@florian-h05 florian-h05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, however I think we can achieve the same without adding more data to addon-store.js. I will push a commit for that.

@florian-h05
Major code improvements
c38c49f 
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
@florian-h05 florian-h05 changed the title Add-on store: title and searchbar focus tweaks Add-on store: Title and searchbar focus tweaks Feb 28, 2024
@florian-h05 florian-h05 added enhancement New feature or request main ui Main UI labels Feb 28, 2024
@florian-h05 florian-h05 added this to the 4.2 milestone Feb 28, 2024
@florian-h05 florian-h05 merged commit 5c1aa89 into openhab:main Feb 28, 2024
6 checks passed
@jimtng jimtng deleted the addons-store branch February 28, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@florian-h05 florian-h05 florian-h05 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request main ui Main UI
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jimtng @florian-h05