Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Settings menu: Fix search bar to include system and addons settings #2409

Merged
merged 1 commit into from Feb 28, 2024
Merged

Settings menu: Fix search bar to include system and addons settings #2409

merged 1 commit into from Feb 28, 2024

Conversation

jimtng
Copy link
Contributor

@jimtng jimtng commented Feb 25, 2024

No description provided.

@jimtng jimtng requested a review from a team as a code owner February 25, 2024 12:43
@relativeci RelativeCI
Copy link

relativeci bot commented Feb 25, 2024 •
edited

Job #1681: Bundle Size — 11.01MiB (~+0.01%).

c1d305e(current) vs 3b694d2 main#1679(baseline)

Warning

Bundle contains 19 duplicate packages – View duplicate packages

Bundle metrics  Change 1 change
                 Current
Job #1681		      Baseline
Job #1679
No change  Initial JS 1.85MiB 1.85MiB
No change  Initial CSS 607.92KiB 607.92KiB
Change  Cache Invalidation 17% 22.84%
No change  Chunks 220 220
No change  Assets 242 242
No change  Modules 3088 3088
No change  Duplicate Modules 164 164
No change  Duplicate Code 1.77% 1.77%
No change  Packages 150 150
No change  Duplicate Packages 18 18
Bundle size by type  Change 1 change Regression 1 regression
                 Current
Job #1681		      Baseline
Job #1679
Regression  JS 9.2MiB (+0.01%) 9.2MiB
Not changed  CSS 889.38KiB 889.38KiB
Not changed  Fonts 526.1KiB 526.1KiB
Not changed  Media 295.6KiB 295.6KiB
Not changed  IMG 140.74KiB 140.74KiB
Not changed  HTML 1.24KiB 1.24KiB
Not changed  Other 871B 871B

View job #1681 report View jimtng:fix-settings-search branch activity View project dashboard

@jimtng jimtng marked this pull request as draft February 25, 2024 13:27
@jimtng jimtng force-pushed the fix-settings-search branch 4 times, most recently from 644d288 to ad3df94 Compare February 25, 2024 14:12
@jimtng
Settings menu: fix search bar to include system and addons settings
c1d305e 
Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
@jimtng jimtng marked this pull request as ready for review February 25, 2024 14:26
florian-h05
florian-h05 approved these changes Feb 28, 2024
View reviewed changes
Copy link
Contributor

@florian-h05 florian-h05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix!

@florian-h05 florian-h05 changed the title Settings menu: fix search bar to include system and addons settings Settings menu: Fix search bar to include system and addons settings Feb 28, 2024
@florian-h05 florian-h05 added bug Something isn't working main ui Main UI labels Feb 28, 2024
@florian-h05 florian-h05 added this to the 4.2 milestone Feb 28, 2024
@florian-h05 florian-h05 merged commit cc62a8f into openhab:main Feb 28, 2024
6 checks passed
@jimtng jimtng deleted the fix-settings-search branch February 28, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@florian-h05 florian-h05 florian-h05 approved these changes

Assignees
No one assigned
Labels
bug Something isn't working main ui Main UI
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jimtng @florian-h05