Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rule module popup: add dirty checking #2412

Merged
merged 2 commits into from Feb 28, 2024
Merged

Conversation

jimtng
Copy link
Contributor

@jimtng jimtng commented Feb 26, 2024

This PR adds dirty checking in the rule module popup.

Rule module popup comes up when you're editing a rule's module, e.g. trigger, action, condition. Previously when you opened the rule module and made changes, then clicked back, you wouldn't get a warning and the changes will simply be lost.

@jimtng jimtng requested a review from a team as a code owner February 26, 2024 08:36
Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
Copy link

relativeci bot commented Feb 26, 2024

Job #1714: Bundle Size — 11.02MiB (~+0.01%).

da28c6f(current) vs cc62a8f main#1713(baseline)

Warning

Bundle contains 19 duplicate packages – View duplicate packages

Bundle metrics  Change 1 change
                 Current
Job #1714
     Baseline
Job #1713
No change  Initial JS 1.85MiB 1.85MiB
No change  Initial CSS 607.92KiB 607.92KiB
Change  Cache Invalidation 18.25% 17%
No change  Chunks 220 220
No change  Assets 242 242
No change  Modules 3089 3089
No change  Duplicate Modules 164 164
No change  Duplicate Code 1.77% 1.77%
No change  Packages 150 150
No change  Duplicate Packages 18 18
Bundle size by type  Change 1 change Regression 1 regression
                 Current
Job #1714
     Baseline
Job #1713
Regression  JS 9.21MiB (~+0.01%) 9.2MiB
Not changed  CSS 889.4KiB 889.4KiB
Not changed  Fonts 526.1KiB 526.1KiB
Not changed  Media 295.6KiB 295.6KiB
Not changed  IMG 140.74KiB 140.74KiB
Not changed  HTML 1.24KiB 1.24KiB
Not changed  Other 871B 871B

View job #1714 reportView jimtng:dirty-module branch activityView project dashboard

@stefan-hoehn
Copy link
Contributor

Would you mind adding some description of what the intent of the change is?

@jimtng
Copy link
Contributor Author

jimtng commented Feb 28, 2024

Updated description

Copy link
Contributor

@florian-h05 florian-h05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Much needed improvement.

@florian-h05 florian-h05 added enhancement New feature or request main ui Main UI labels Feb 28, 2024
@florian-h05 florian-h05 added this to the 4.2 milestone Feb 28, 2024
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
@florian-h05 florian-h05 merged commit 22fe3f0 into openhab:main Feb 28, 2024
6 checks passed
@jimtng jimtng deleted the dirty-module branch February 28, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request main ui Main UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants