Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blockly Editor: combine renderer selection and show item label icons #2415

Merged
merged 3 commits into from Feb 26, 2024

Conversation

jimtng
Copy link
Contributor

@jimtng jimtng commented Feb 26, 2024

The current icons are too crowded for mobile devices. This PR combines the renderer choice and the show labels into one icon.

Before
image

After
image

@jimtng jimtng requested a review from a team as a code owner February 26, 2024 13:54
Copy link

relativeci bot commented Feb 26, 2024

Job #1692: Bundle Size — 11.01MiB (~+0.01%).

716e8d8(current) vs e2738b5 main#1690(baseline)

Warning

Bundle contains 19 duplicate packages – View duplicate packages

Bundle metrics  Change 1 change
                 Current
Job #1692
     Baseline
Job #1690
No change  Initial JS 1.85MiB 1.85MiB
No change  Initial CSS 607.92KiB 607.92KiB
Change  Cache Invalidation 16.99% 16.76%
No change  Chunks 220 220
No change  Assets 242 242
No change  Modules 3088 3088
No change  Duplicate Modules 164 164
No change  Duplicate Code 1.77% 1.77%
No change  Packages 150 150
No change  Duplicate Packages 18 18
Bundle size by type  Change 1 change Regression 1 regression
                 Current
Job #1692
     Baseline
Job #1690
Regression  JS 9.2MiB (+0.01%) 9.2MiB
Not changed  CSS 889.38KiB 889.38KiB
Not changed  Fonts 526.1KiB 526.1KiB
Not changed  Media 295.6KiB 295.6KiB
Not changed  IMG 140.74KiB 140.74KiB
Not changed  HTML 1.24KiB 1.24KiB
Not changed  Other 871B 871B

View job #1692 reportView jimtng:blockly-renderer-icons branch activityView project dashboard

Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
@jimtng
Copy link
Contributor Author

jimtng commented Feb 26, 2024

The second commit capitalizes the renderer name. I think it looks nicer

image

@florian-h05
Copy link
Contributor

For mobile phones, this looks really good!
I however wonder if the options however shouldn’t stay separated on big enough screens for faster access.

@jimtng
Copy link
Contributor Author

jimtng commented Feb 26, 2024

I however wonder if the options however shouldn’t stay separated on big enough screens for faster access.

I agree. Just need to add more code. I'll add that tomorrow.

@jimtng
Copy link
Contributor Author

jimtng commented Feb 26, 2024

It wasn't too hard, so I've made the changes.

On desktop it now looks like this (with an icon instead of the name)
image

Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
Copy link
Member

@ghys ghys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does look good, thank you!

@ghys ghys merged commit 565844f into openhab:main Feb 26, 2024
6 checks passed
@florian-h05 florian-h05 added enhancement New feature or request main ui Main UI labels Feb 26, 2024
@florian-h05 florian-h05 added this to the 4.2 milestone Feb 26, 2024
@jimtng jimtng deleted the blockly-renderer-icons branch February 27, 2024 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request main ui Main UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants