New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Blockly Editor: combine renderer selection and show item label icons #2415
Conversation
Job #1692: Bundle Size — 11.01MiB (~+0.01%).Warning Bundle contains 19 duplicate packages – View duplicate packages Bundle metrics
Bundle size by type
View job #1692 report View jimtng:blockly-renderer-icons branch activity View project dashboard |
bf28365
to
d445f11
Compare
Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
d445f11
to
19f34cd
Compare
Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
For mobile phones, this looks really good! |
I agree. Just need to add more code. I'll add that tomorrow. |
Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
e908e41
to
716e8d8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It does look good, thank you!
The current icons are too crowded for mobile devices. This PR combines the renderer choice and the show labels into one icon.
Before
After