New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[blockly] Add multi-select feature #2419
Conversation
Job #1728: Bundle Size — 11.11MiB (+0.74%).Warning Bundle contains 19 duplicate packages – View duplicate packages Warning Bundle introduced 2 new packages: @mit-app-inventor/blockly-plugin-workspace-multiselect, dragselect – View changed packages Bundle metrics
Bundle size by type
View job #1728 report View jimtng:blockly-multi-select branch activity View project dashboard |
Thank you! This was really annoying when I was trying to do some testing of my block library. |
I also need to check closely that it removes the cross-tab-plugin. |
@stefan-hoehn This is fixed in v0.1.12 which I have updated in this PR. It's added as a separate commit for you to see the changes, but I can squash it into the corresponding commit before merging. Could you please test it again? |
d9be766
to
2bc736e
Compare
Ok, I tested it again and from what I see it looks good. Can you please not only provide this PR but also the PR that updates the docs accordingly 🙏🏻, so the users are not confused as we had "cross rule copy" before and now the new behaviour. Also multiselect should be described. So in particular https://next.openhab.org/docs/configuration/blockly/rules-blockly-before-using.html#cross-rule-copy-paste should be updated at best with a new animated gif that explains how to use the new functionality. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I just had a look at it, and this is a really nice feature!
It conflicts with the multi-select plugin and the same functionality is provided by the multi-select plugin Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
2bc736e
to
e8f3891
Compare
Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
e8f3891
to
f4bd025
Compare
@jimtng FYI I updated the commit messages a bit so these contain a reference to this PR when I rebase. |
It conflicts with the multi-select plugin and the same functionality is provided by the multi-select plugin Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
openhab/openhab-webui#2419 Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
openhab/openhab-webui#2419 Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
openhab/openhab-webui#2419 Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
openhab/openhab-webui#2419 Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
openhab/openhab-webui#2419 Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
openhab/openhab-webui#2419 Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
openhab/openhab-webui#2419 Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au> Co-authored-by: stefan-hoehn <mail@stefanhoehn.com>
The multi-select plugin conflicts with the cross-tab-copy-paste plugin and makes it redundant, so it is removed in this PR
Also in this PR, make two fingers do panning instead of zooming.
These have been split into three commits for granularity so please don't squash them.
Resolve #2417