Location card: Swap status & measurement badges to avoid layout shift #2425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The status badges are displayed based on the actual state of that status category. This causes the measurement badges, which are always shown to be either first or second line. This swaps those, so that measurement badges don't move around anymore. Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
|
Supersedes #2198. |
Job #1718: Bundle Size — 11.02MiB (0%).Warning Bundle contains 19 duplicate packages – View duplicate packages Bundle metrics
Bundle size by type
|
| Current Job #1718 |
Baseline Job #1717 |
|
|---|---|---|
 |
9.21MiB |
9.21MiB |
|
889.4KiB |
889.4KiB |
|
526.1KiB |
526.1KiB |
|
295.6KiB |
295.6KiB |
|
140.74KiB |
140.74KiB |
|
1.24KiB |
1.24KiB |
|
871B |
871B |
View job #1718 report View florian-h05:location-card branch activity View project dashboard
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The status badges are displayed based on the actual state of that status category. This causes the measurement badges, which are always shown to be either first or second line.
This swaps those, so that measurement badges don't move around anymore.