Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Item picker: Disable picker & hide chevron if not yet ready #2428

Merged
merged 1 commit into from Feb 28, 2024
Merged

Item picker: Disable picker & hide chevron if not yet ready #2428

merged 1 commit into from Feb 28, 2024

Conversation

florian-h05
Copy link
Contributor

No description provided.

@florian-h05
Item picker: Disable picker if not yet ready
cf750d0 
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
@florian-h05 florian-h05 requested a review from a team as a code owner February 28, 2024 17:24
@florian-h05 florian-h05 added enhancement New feature or request main ui Main UI labels Feb 28, 2024
@florian-h05 florian-h05 added this to the 4.2 milestone Feb 28, 2024
@florian-h05
Copy link
Contributor Author

Supersedes #1066.
Please note that I have not picked up the type filter improvements (in general, I like them) , because the type filter on the server requires exact match with the type, which does not allow to filter by all Number[:...] Items.

@florian-h05 florian-h05 mentioned this pull request Feb 28, 2024
Closed
@relativeci RelativeCI
Copy link

relativeci bot commented Feb 28, 2024

Job #1722: Bundle Size — 11.02MiB (~+0.01%).

cf750d0(current) vs 76e6316 main#1721(baseline)

Warning

Bundle contains 19 duplicate packages – View duplicate packages

Bundle metrics  Change 1 change
                 Current
Job #1722		      Baseline
Job #1721
No change  Initial JS 1.85MiB 1.85MiB
No change  Initial CSS 607.92KiB 607.92KiB
Change  Cache Invalidation 18.17% 16.76%
No change  Chunks 220 220
No change  Assets 242 242
No change  Modules 3089 3089
No change  Duplicate Modules 164 164
No change  Duplicate Code 1.77% 1.77%
No change  Packages 150 150
No change  Duplicate Packages 18 18
Bundle size by type  Change 1 change Regression 1 regression
                 Current
Job #1722		      Baseline
Job #1721
Regression  JS 9.21MiB (~+0.01%) 9.21MiB
Not changed  CSS 889.4KiB 889.4KiB
Not changed  Fonts 526.1KiB 526.1KiB
Not changed  Media 295.6KiB 295.6KiB
Not changed  IMG 140.74KiB 140.74KiB
Not changed  HTML 1.24KiB 1.24KiB
Not changed  Other 871B 871B

View job #1722 report View florian-h05:item-picker branch activity View project dashboard

@florian-h05 florian-h05 merged commit 9096d6d into openhab:main Feb 28, 2024
6 checks passed
@florian-h05 florian-h05 deleted the item-picker branch February 29, 2024 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request main ui Main UI
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@florian-h05