New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade echarts and vue-echarts & Add fallback for visualMap when using heatmap #2450
Conversation
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Job #1807: Bundle Size — 11.15MiB (+0.2%).Warning Bundle contains 19 duplicate packages – View duplicate packages Warning Bundle introduced 2 new packages: vue-demi, @vue/composition-api – View changed packages Bundle metrics
Bundle size by type
View job #1807 report View florian-h05:upgrade-echarts branch activity View project dashboard |
I tested it on my side. Even though openHAB charts seem to work, the network chart in the Z-Wave plugin does not. The latter doesn't even through an exception in the logs or anything obvious shows up in the console. |
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
I can confirm that it works now as it should. Looks good to me overall. Hope I have not overseen something. |
This upgrades
echarts
andvue-echarts
to the latest versions.@vue/composition-api
was added as dependency becausevue-echarts
needs it on Vue 2.See https://echarts.apache.org/handbook/en/basics/release-note/v5-upgrade-guide/ and https://github.com/ecomfe/vue-echarts#migration-to-v6 for upgrade guides.
This also adds a fallback default for
visualMap
because it is required to define avisualMap
when using a heatmap, otherwise echarts fails to render the chart.Even though the docs and the chart-designer mentioned this until now, it worked without defining a visualmap, which would not be the case anymore (and therefore break charts - defining a visual map is easy though) without providing a fallback.