Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade echarts and vue-echarts & Add fallback for visualMap when using heatmap #2450

Merged
merged 6 commits into from Mar 14, 2024

Conversation

florian-h05
Copy link
Contributor

@florian-h05 florian-h05 commented Mar 4, 2024

This upgrades echarts and vue-echarts to the latest versions.
@vue/composition-api was added as dependency because vue-echarts needs it on Vue 2.

See https://echarts.apache.org/handbook/en/basics/release-note/v5-upgrade-guide/ and https://github.com/ecomfe/vue-echarts#migration-to-v6 for upgrade guides.

This also adds a fallback default for visualMap because it is required to define a visualMap when using a heatmap, otherwise echarts fails to render the chart.
Even though the docs and the chart-designer mentioned this until now, it worked without defining a visualmap, which would not be the case anymore (and therefore break charts - defining a visual map is easy though) without providing a fallback.

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
@florian-h05 florian-h05 requested a review from a team as a code owner March 4, 2024 18:44
@florian-h05 florian-h05 added enhancement New feature or request main ui Main UI labels Mar 4, 2024
@florian-h05 florian-h05 added this to the 4.2 milestone Mar 4, 2024
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Copy link

relativeci bot commented Mar 4, 2024

Job #1807: Bundle Size — 11.15MiB (+0.2%).

d31bbed(current) vs 1ceb5c6 main#1804(baseline)

Warning

Bundle contains 19 duplicate packages – View duplicate packages

Warning

Bundle introduced 2 new packages: vue-demi, @vue/composition-api – View changed packages

Bundle metrics  Change 8 changes Regression 1 regression Improvement 3 improvements
                 Current
Job #1807
     Baseline
Job #1804
Improvement  Initial JS 1.84MiB(~-0.01%) 1.84MiB
No change  Initial CSS 607.88KiB 607.88KiB
Change  Cache Invalidation 18.73% 17.13%
Change  Chunks 219(-0.45%) 220
Change  Assets 242(-0.41%) 243
Change  Modules 3051(-1.33%) 3092
Improvement  Duplicate Modules 144(-12.2%) 164
Improvement  Duplicate Code 1.69%(-3.43%) 1.75%
Regression  Packages 153(+1.32%) 151
No change  Duplicate Packages 18 18
Bundle size by type  Change 2 changes Regression 1 regression Improvement 1 improvement
                 Current
Job #1807
     Baseline
Job #1804
Regression  JS 9.34MiB (+0.24%) 9.32MiB
Improvement  CSS 889.25KiB (-0.01%) 889.35KiB
Not changed  Fonts 526.1KiB 526.1KiB
Not changed  Media 295.6KiB 295.6KiB
Not changed  IMG 140.74KiB 140.74KiB
Not changed  HTML 1.24KiB 1.24KiB
Not changed  Other 871B 871B

View job #1807 reportView florian-h05:upgrade-echarts branch activityView project dashboard

@stefan-hoehn
Copy link
Contributor

I tested it on my side. Even though openHAB charts seem to work, the network chart in the Z-Wave plugin does not. The latter doesn't even through an exception in the logs or anything obvious shows up in the console.

@florian-h05 florian-h05 marked this pull request as draft March 14, 2024 17:39
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
@stefan-hoehn
Copy link
Contributor

I can confirm that it works now as it should. Looks good to me overall. Hope I have not overseen something.

@florian-h05 florian-h05 marked this pull request as ready for review March 14, 2024 19:51
@florian-h05 florian-h05 merged commit 021c3d8 into openhab:main Mar 14, 2024
6 checks passed
@florian-h05 florian-h05 deleted the upgrade-echarts branch March 14, 2024 19:56
@florian-h05 florian-h05 added the dependencies Pull requests that update a dependency file label Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request main ui Main UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants