Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Item name validation #2451

Merged
merged 2 commits into from Mar 4, 2024
Merged

Improve Item name validation #2451

merged 2 commits into from Mar 4, 2024

Conversation

florian-h05
Copy link
Contributor

Check that an Item name does not start with a number.

Closes #2444.

@florian-h05
Improve Item name validation
a6d8684 
Check that an Item name does not start with a number.

Closes openhab#2444.

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
@florian-h05 florian-h05 requested a review from a team as a code owner March 4, 2024 19:06
@florian-h05 florian-h05 added enhancement New feature or request main ui Main UI labels Mar 4, 2024
@florian-h05 florian-h05 added this to the 4.2 milestone Mar 4, 2024
@florian-h05 florian-h05 mentioned this pull request Mar 4, 2024
Closed
@relativeci RelativeCI
Copy link

relativeci bot commented Mar 4, 2024 •
edited

Job #1774: Bundle Size — 11.13MiB (~+0.01%).

2620b37(current) vs ccaa221 main#1771(baseline)

Warning

Bundle contains 19 duplicate packages – View duplicate packages

Bundle metrics  Change 2 changes Regression 1 regression
                 Current
Job #1774		      Baseline
Job #1771
Regression  Initial JS 1.84MiB(~+0.01%) 1.84MiB
No change  Initial CSS 607.88KiB 607.88KiB
Change  Cache Invalidation 16.53% 16.76%
No change  Chunks 220 220
No change  Assets 243 243
No change  Modules 3091 3091
No change  Duplicate Modules 164 164
No change  Duplicate Code 1.75% 1.75%
No change  Packages 151 151
No change  Duplicate Packages 18 18
Bundle size by type  Change 1 change Regression 1 regression
                 Current
Job #1774		      Baseline
Job #1771
Regression  JS 9.31MiB (~+0.01%) 9.31MiB
Not changed  CSS 889.35KiB 889.35KiB
Not changed  Fonts 526.1KiB 526.1KiB
Not changed  Media 295.6KiB 295.6KiB
Not changed  IMG 140.74KiB 140.74KiB
Not changed  HTML 1.24KiB 1.24KiB
Not changed  Other 871B 871B

View job #1774 report View florian-h05:item-name-validation branch activity View project dashboard

@florian-h05
Address review
2620b37 
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
@florian-h05 florian-h05 merged commit e288d0b into openhab:main Mar 4, 2024
6 checks passed
@florian-h05 florian-h05 deleted the item-name-validation branch March 4, 2024 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mherwege mherwege mherwege left review comments

Assignees
No one assigned
Labels
enhancement New feature or request main ui Main UI
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

"An error occurred while creating the items: Bad Request"
2 participants
@florian-h05 @mherwege