Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Item details: Fix editing groups with uneditable members & Sort members #2452

Merged
merged 2 commits into from Mar 6, 2024
Merged

Item details: Fix editing groups with uneditable members & Sort members #2452

merged 2 commits into from Mar 6, 2024

Conversation

jimtng
Copy link
Contributor

@jimtng jimtng commented Mar 5, 2024

Fix #2427

Also sort the list of group members alphabetically based on label or name.

@jimtng
Item Details: fix editing group members with uneditable members
1b110e6 
Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
@jimtng
Item Details: sort the list of group members
4ebbe56 
Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
@jimtng jimtng requested a review from a team as a code owner March 5, 2024 08:25
@jimtng jimtng changed the title Item Details: fix editing group members with uneditable members Item Details: sort the group members and fix editing with uneditable members Mar 5, 2024
@relativeci RelativeCI
Copy link

relativeci bot commented Mar 5, 2024

Job #1777: Bundle Size — 11.12MiB (~+0.01%).

4ebbe56(current) vs 4af22ff main#1776(baseline)

Warning

Bundle contains 19 duplicate packages – View duplicate packages

Bundle metrics  Change 1 change Regression 1 regression
                 Current
Job #1777		      Baseline
Job #1776
Regression  Initial JS 1.84MiB(~+0.01%) 1.84MiB
No change  Initial CSS 607.88KiB 607.88KiB
No change  Cache Invalidation 17.12% 17.12%
No change  Chunks 220 220
No change  Assets 243 243
No change  Modules 3091 3091
No change  Duplicate Modules 164 164
No change  Duplicate Code 1.75% 1.75%
No change  Packages 151 151
No change  Duplicate Packages 18 18
Bundle size by type  Change 1 change Regression 1 regression
                 Current
Job #1777		      Baseline
Job #1776
Regression  JS 9.31MiB (~+0.01%) 9.31MiB
Not changed  CSS 889.35KiB 889.35KiB
Not changed  Fonts 526.1KiB 526.1KiB
Not changed  Media 295.6KiB 295.6KiB
Not changed  IMG 140.74KiB 140.74KiB
Not changed  HTML 1.24KiB 1.24KiB
Not changed  Other 871B 871B

View job #1777 report View jimtng:fix-member-edit branch activity View project dashboard

florian-h05
florian-h05 approved these changes Mar 6, 2024
View reviewed changes
Copy link
Contributor

@florian-h05 florian-h05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. thanks!

@florian-h05 florian-h05 added bug Something isn't working main ui Main UI labels Mar 6, 2024
@florian-h05 florian-h05 added this to the 4.2 milestone Mar 6, 2024
@florian-h05 florian-h05 changed the title Item Details: sort the group members and fix editing with uneditable members Item detaiils: Fix editing groups with uneditable members & Sort group members Mar 6, 2024
@florian-h05 florian-h05 changed the title Item detaiils: Fix editing groups with uneditable members & Sort group members Item detaiils: Fix editing groups with uneditable members & Sort members Mar 6, 2024
@florian-h05 florian-h05 changed the title Item detaiils: Fix editing groups with uneditable members & Sort members Item details: Fix editing groups with uneditable members & Sort members Mar 6, 2024
@florian-h05 florian-h05 merged commit 67e8ed4 into openhab:main Mar 6, 2024
6 checks passed
@jimtng jimtng deleted the fix-member-edit branch March 7, 2024 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@florian-h05 florian-h05 florian-h05 approved these changes

Assignees
No one assigned
Labels
bug Something isn't working main ui Main UI
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

Deleting direct group members when uneditable members exist
2 participants
@jimtng @florian-h05