Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dirty warning shown on delete #2470

Merged
merged 1 commit into from Mar 12, 2024
Merged

Fix dirty warning shown on delete #2470

merged 1 commit into from Mar 12, 2024

Conversation

florian-h05
Copy link
Contributor

Fixes #2462.

@florian-h05
Fix dirty warning shown on delete
3320595 
Fixes openhab#2462.

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
@florian-h05 florian-h05 requested a review from a team as a code owner March 12, 2024 22:06
@relativeci RelativeCI
Copy link

relativeci bot commented Mar 12, 2024

Job #1791: Bundle Size — 11.13MiB (~-0.01%).

3320595(current) vs 9f006fd main#1790(baseline)

Warning

Bundle contains 19 duplicate packages – View duplicate packages

Bundle metrics  Change 2 changes Regression 1 regression
                 Current
Job #1791		      Baseline
Job #1790
Regression  Initial JS 1.84MiB(~+0.01%) 1.84MiB
No change  Initial CSS 607.88KiB 607.88KiB
Change  Cache Invalidation 17.36% 17.06%
No change  Chunks 220 220
No change  Assets 243 243
No change  Modules 3092 3092
No change  Duplicate Modules 164 164
No change  Duplicate Code 1.75% 1.75%
No change  Packages 151 151
No change  Duplicate Packages 18 18
Bundle size by type  Change 1 change Improvement 1 improvement
                 Current
Job #1791		      Baseline
Job #1790
Improvement  JS 9.32MiB (~-0.01%) 9.32MiB
Not changed  CSS 889.35KiB 889.35KiB
Not changed  Fonts 526.1KiB 526.1KiB
Not changed  Media 295.6KiB 295.6KiB
Not changed  IMG 140.74KiB 140.74KiB
Not changed  HTML 1.24KiB 1.24KiB
Not changed  Other 871B 871B

View job #1791 report View florian-h05:fix-dirty-msg-on-del... branch activity View project dashboard

@florian-h05 florian-h05 added bug Something isn't working main ui Main UI rebuild trigger a new Jenkins job and removed rebuild trigger a new Jenkins job labels Mar 12, 2024
@florian-h05 florian-h05 added this to the 4.2 milestone Mar 12, 2024
@florian-h05 florian-h05 merged commit c41aa38 into openhab:main Mar 12, 2024
6 checks passed
@florian-h05 florian-h05 deleted the fix-dirty-msg-on-delete branch March 12, 2024 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working main ui Main UI
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

Redundant "Changes have not been saved" dialog
1 participant
@florian-h05