New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[blockly] Fix missing event property causes JS error #2476
[blockly] Fix missing event property causes JS error #2476
Conversation
Signed-off-by: Stefan Höhn <mail@stefanhoehn.com>
Job #1837: Bundle Size — 10.55MiB (~+0.01%).Warning Bundle contains 2 duplicate packages – View duplicate packages Bundle metrics
Bundle size by type
View job #1837 report View stefan-hoehn:blockly_eventcontex... branch activity View project dashboard |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please have a look at my comments.
bundles/org.openhab.ui/web/src/assets/definitions/blockly/blocks-scripts.js
Outdated
Show resolved
Hide resolved
bundles/org.openhab.ui/web/src/assets/definitions/blockly/blocks-scripts.js
Outdated
Show resolved
Hide resolved
Signed-off-by: Stefan Höhn <mail@stefanhoehn.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
See https://community.openhab.org/t/blockly-proposal-to-change-contextual-info-blocks/154403/27. Signed-off-by: Stefan Höhn <mail@stefanhoehn.com> (cherry picked from commit 32b8b88)
see https://community.openhab.org/t/blockly-proposal-to-change-contextual-info-blocks/154403/27