Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Link Item to channel: Include error message on name validation failure #2487

Merged
merged 2 commits into from Mar 21, 2024
Merged

Link Item to channel: Include error message on name validation failure #2487

merged 2 commits into from Mar 21, 2024

Conversation

jimtng
Copy link
Contributor

@jimtng jimtng commented Mar 19, 2024

No description provided.

@jimtng jimtng requested a review from a team as a code owner March 19, 2024 21:58
@jimtng
Linking to a new item: include the error message on name validation f…
c6c44cc 
…ailure

Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
@relativeci RelativeCI
Copy link

relativeci bot commented Mar 19, 2024 •
edited

Job #1832: Bundle Size — 10.55MiB (~+0.01%).

15d889e(current) vs 162cc1a main#1831(baseline)

Warning

Bundle contains 2 duplicate packages – View duplicate packages

Bundle metrics  Change 1 change
                 Current
Job #1832		      Baseline
Job #1831
No change  Initial JS 1.86MiB 1.86MiB
No change  Initial CSS 607.87KiB 607.87KiB
Change  Cache Invalidation 18.31% 25.42%
No change  Chunks 223 223
No change  Assets 246 246
No change  Modules 2857 2857
No change  Duplicate Modules 141 141
No change  Duplicate Code 1.73% 1.73%
No change  Packages 94 94
No change  Duplicate Packages 2 2
Bundle size by type  Change 1 change Regression 1 regression
                 Current
Job #1832		      Baseline
Job #1831
Regression  JS 8.74MiB (~+0.01%) 8.74MiB
Not changed  CSS 890.03KiB 890.03KiB
Not changed  Fonts 526.1KiB 526.1KiB
Not changed  Media 295.6KiB 295.6KiB
Not changed  IMG 140.74KiB 140.74KiB
Not changed  HTML 1.24KiB 1.24KiB
Not changed  Other 871B 871B

View job #1832 report View jimtng:link-add-validate-msg branch activity View project dashboard

florian-h05
florian-h05 reviewed Mar 21, 2024
View reviewed changes
Copy link
Contributor

@florian-h05 florian-h05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment:

bundles/org.openhab.ui/web/src/pages/settings/things/link/link-add.vue Outdated Show resolved Hide resolved
@jimtng
Copy link
Contributor Author

jimtng commented Mar 21, 2024

@florian-h05 please apply change and commit. I'm afk for a while.

@florian-h05
Update bundles/org.openhab.ui/web/src/pages/settings/things/link/link…
15d889e 
…-add.vue

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
@florian-h05 florian-h05 added enhancement New feature or request main ui Main UI labels Mar 21, 2024
@florian-h05 florian-h05 added this to the 4.2 milestone Mar 21, 2024
@florian-h05 florian-h05 changed the title Linking to a new item: include the error message on name validation failure Link channel to Item: Include error message on name validation failure Mar 21, 2024
@florian-h05 florian-h05 merged commit 1bebae3 into openhab:main Mar 21, 2024
6 checks passed
@florian-h05 florian-h05 changed the title Link channel to Item: Include error message on name validation failure Link Item to channel: Include error message on name validation failure Mar 21, 2024
@jimtng jimtng deleted the link-add-validate-msg branch March 24, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@florian-h05 florian-h05 florian-h05 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request main ui Main UI
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jimtng @florian-h05