Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade several dependencies #2488

Merged
merged 17 commits into from Mar 21, 2024
Merged

Upgrade several dependencies #2488

merged 17 commits into from Mar 21, 2024

Conversation

florian-h05
Copy link
Contributor

@florian-h05 florian-h05 commented Mar 21, 2024 •
edited

This PR upgrades all dependencies of Main UI to the latest version that is compatible with Vue 2.6.12.

I have built and tested this PR in general as well as each individual commit, it is working fine.

@florian-h05 florian-h05 requested a review from a team as a code owner March 21, 2024 16:11
@florian-h05
Upgrade jse-eval with plugins
4a47c1d 
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
@florian-h05
Upgrade cronstrue
1525732 
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
@florian-h05
Upgrade dayjs
6d36269 
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
@florian-h05
Upgrade jssip
0f96cb1 
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
@florian-h05
Upgrade leaflet
4e7da62 
Map and floor-plan pages were tested and are still working.

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
@florian-h05
Upgrade lodash
c3486d4 
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
@florian-h05
Upgrade moo & nearley
07d759a 
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
@florian-h05
Upgrade pkce-challenge
8c734d9 
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
@florian-h05
Upgrade qrcode
c4eecb5 
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
@florian-h05
Remove sprintf-js
db48544 
This dependency was not used and hence can be removed.

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
@florian-h05
Upgrade tern
0d78f3b 
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
@florian-h05
Upgrade vue-fragment
e60df82 
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
@florian-h05
Upgrade vue-fullscreen
75ffc1b 
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
@florian-h05
Upgrade vue-grid-layout
7800b2d 
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
@florian-h05
Upgrade vue-i18n & Silence translation fallback warnings
d112c30 
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
@florian-h05
Upgrade yaml
e9c9f5e 
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
@florian-h05
Upgrade vuex
52675ef 
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
@relativeci RelativeCI
Copy link

relativeci bot commented Mar 21, 2024

Job #1824: Bundle Size — 10.55MiB (-5.33%).

52675ef(current) vs 67163b0 main#1817(baseline)

Warning

Bundle removed 17 duplicate packages, 2 duplicate packages remaining – View duplicate packages

Warning

Bundle introduced one new package: encode-utf8 – View changed packages

Bundle metrics  Change 9 changes Regression 2 regressions Improvement 3 improvements
                 Current
Job #1824		      Baseline
Job #1817
Regression  Initial JS 1.85MiB(+0.33%) 1.84MiB
No change  Initial CSS 607.88KiB 607.88KiB
Change  Cache Invalidation 21.05% 0%
Change  Chunks 223(+1.83%) 219
Change  Assets 246(+1.65%) 242
Change  Modules 2858(-6.33%) 3051
Improvement  Duplicate Modules 141(-2.08%) 144
Regression  Duplicate Code 1.71%(+1.18%) 1.69%
Improvement  Packages 95(-37.91%) 153
Improvement  Duplicate Packages 2(-88.89%) 18
Bundle size by type  Change 2 changes Regression 1 regression Improvement 1 improvement
                 Current
Job #1824		      Baseline
Job #1817
Improvement  JS 8.74MiB (-6.37%) 9.34MiB
Regression  CSS 890.04KiB (+0.09%) 889.25KiB
Not changed  Fonts 526.1KiB 526.1KiB
Not changed  Media 295.6KiB 295.6KiB
Not changed  IMG 140.74KiB 140.74KiB
Not changed  HTML 1.24KiB 1.24KiB
Not changed  Other 871B 871B

View job #1824 report View florian-h05:upgrades branch activity View project dashboard

@florian-h05 florian-h05 merged commit 577d6ed into openhab:main Mar 21, 2024
6 checks passed
@florian-h05 florian-h05 deleted the upgrades branch March 21, 2024 16:24
@florian-h05 florian-h05 added this to the 4.2 milestone Mar 21, 2024
@florian-h05 florian-h05 added enhancement New feature or request main ui Main UI dependencies Pull requests that update a dependency file labels Mar 21, 2024
@florian-h05 florian-h05 mentioned this pull request Mar 29, 2024
Merged
florian-h05 added a commit that referenced this pull request Mar 29, 2024
@florian-h05
Downgrade pkce-challenge to fix authentication for insecure (HTTP) co…
4d5a4a4 
…ntexts (#2510)

Regression from #2488.

Version 4.x of pkce-challenge uses the Web Crypto API, which is only
available in secure contexts (https) in most browsers.
This broke the login when accessing the UI over an insecure (plain HTTP)
connection.
See https://developer.mozilla.org/en-US/docs/Web/API/Web_Crypto_API.

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request main ui Main UI
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@florian-h05