Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rule edit: Always create script field for script action/condition #2497

Merged
merged 1 commit into from Mar 24, 2024
Merged

Rule edit: Always create script field for script action/condition #2497

merged 1 commit into from Mar 24, 2024

Conversation

florian-h05
Copy link
Contributor

@florian-h05 florian-h05 commented Mar 24, 2024 •
edited

Fixes #2461.
Depends on openhab/openhab-core#4148.

@florian-h05
Rule edit: Fix missing script field when creating script action/condi…
27c1739 
…tion with empty script

Fixes openhab#2461.
Depends on openhab/openhab-core#4148.

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
@florian-h05 florian-h05 requested a review from a team as a code owner March 24, 2024 21:18
@florian-h05 florian-h05 added bug Something isn't working main ui Main UI labels Mar 24, 2024
@florian-h05 florian-h05 added this to the 4.2 milestone Mar 24, 2024
@relativeci RelativeCI
Copy link

relativeci bot commented Mar 24, 2024

Job #1845: Bundle Size — 10.55MiB (~+0.01%).

27c1739(current) vs f2f9f58 main#1843(baseline)

Warning

Bundle contains 2 duplicate packages – View duplicate packages

Bundle metrics  Change 1 change
                 Current
Job #1845		      Baseline
Job #1843
No change  Initial JS 1.86MiB 1.86MiB
No change  Initial CSS 607.87KiB 607.87KiB
Change  Cache Invalidation 17.89% 0%
No change  Chunks 223 223
No change  Assets 246 246
No change  Modules 2857 2857
No change  Duplicate Modules 141 141
No change  Duplicate Code 1.73% 1.73%
No change  Packages 94 94
No change  Duplicate Packages 2 2
Bundle size by type  Change 1 change Regression 1 regression
                 Current
Job #1845		      Baseline
Job #1843
Regression  JS 8.74MiB (~+0.01%) 8.74MiB
Not changed  CSS 890.03KiB 890.03KiB
Not changed  Fonts 526.1KiB 526.1KiB
Not changed  Media 295.6KiB 295.6KiB
Not changed  IMG 140.74KiB 140.74KiB
Not changed  HTML 1.24KiB 1.24KiB
Not changed  Other 871B 871B

View job #1845 report View florian-h05:fix-2461 branch activity View project dashboard

@florian-h05 florian-h05 merged commit 3a37d01 into openhab:main Mar 24, 2024
6 checks passed
@florian-h05 florian-h05 deleted the fix-2461 branch March 24, 2024 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working main ui Main UI
Projects
None yet
Milestone
4.2
1 participant
@florian-h05