Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sitemap edit: Fix attribute-details styling applies globally #2500

Merged
merged 1 commit into from Mar 24, 2024
Merged

Sitemap edit: Fix attribute-details styling applies globally #2500

merged 1 commit into from Mar 24, 2024

Conversation

florian-h05
Copy link
Contributor

Fixes #2456.

@florian-h05
Sitemap edit: Fix attribute-details styling gets applied globally
0da88e0 
Fixes openhab#2456.

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
@florian-h05 florian-h05 requested a review from a team as a code owner March 24, 2024 22:19
@florian-h05 florian-h05 added bug Something isn't working main ui Main UI labels Mar 24, 2024
@florian-h05 florian-h05 added this to the 4.2 milestone Mar 24, 2024
@florian-h05 florian-h05 changed the title Sitemap edit: Fix attribute-details styling gets applied globally Sitemap edit: Fix attribute-details styling appliew globally Mar 24, 2024
@florian-h05 florian-h05 changed the title Sitemap edit: Fix attribute-details styling appliew globally Sitemap edit: Fix attribute-details styling applies globally Mar 24, 2024
@florian-h05 florian-h05 mentioned this pull request Mar 24, 2024
Closed
@relativeci RelativeCI
Copy link

relativeci bot commented Mar 24, 2024

Job #1851: Bundle Size — 10.55MiB (~+0.01%).

0da88e0(current) vs 6ed3683 main#1850(baseline)

Warning

Bundle contains 2 duplicate packages – View duplicate packages

Bundle metrics  Change 2 changes
                 Current
Job #1851		      Baseline
Job #1850
No change  Initial JS 1.86MiB 1.86MiB
No change  Initial CSS 607.87KiB 607.87KiB
Change  Cache Invalidation 17.81% 18.31%
No change  Chunks 223 223
No change  Assets 246 246
Change  Modules 2856(-0.04%) 2857
No change  Duplicate Modules 141 141
No change  Duplicate Code 1.73% 1.73%
No change  Packages 94 94
No change  Duplicate Packages 2 2
Bundle size by type  Change 2 changes Regression 1 regression Improvement 1 improvement
                 Current
Job #1851		      Baseline
Job #1850
Regression  JS 8.74MiB (~+0.01%) 8.74MiB
Improvement  CSS 889.97KiB (~-0.01%) 890.03KiB
Not changed  Fonts 526.1KiB 526.1KiB
Not changed  Media 295.6KiB 295.6KiB
Not changed  IMG 140.74KiB 140.74KiB
Not changed  HTML 1.24KiB 1.24KiB
Not changed  Other 871B 871B

View job #1851 report View florian-h05:sitemap-editor-widge... branch activity View project dashboard

@florian-h05 florian-h05 merged commit 577568d into openhab:main Mar 24, 2024
6 checks passed
@florian-h05 florian-h05 deleted the sitemap-editor-widget-attribute-style branch March 24, 2024 22:48
florian-h05 added a commit to florian-h05/openhab-webui that referenced this pull request Mar 25, 2024
@florian-h05
Things list: Fix location tab
4b76949 
Regression from openhab#2500.

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
@florian-h05 florian-h05 mentioned this pull request Mar 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working main ui Main UI
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

Right padding on the main UI add-on store buttons
1 participant
@florian-h05