Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Things list: Fix broken list index after Thing removal #2515

Merged
merged 1 commit into from Mar 30, 2024
Merged

Things list: Fix broken list index after Thing removal #2515

merged 1 commit into from Mar 30, 2024

Conversation

florian-h05
Copy link
Contributor

After a Thing has been removed, the list index showed several wrong entries derived from Thing labels.

@florian-h05
Things list: Fix list index broken after Thing removal
e77562b 
After a Thing has been removed, the list index showed several wrong entries.
This PR fixes this.

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
@florian-h05 florian-h05 requested a review from a team as a code owner March 30, 2024 21:01
@florian-h05 florian-h05 added bug Something isn't working main ui Main UI labels Mar 30, 2024
@florian-h05 florian-h05 added this to the 4.2 milestone Mar 30, 2024
@florian-h05 florian-h05 changed the title Things list: Fix list index broken after Thing removal Things list: Fix broken list index after Thing removal Mar 30, 2024
@relativeci RelativeCI
Copy link

relativeci bot commented Mar 30, 2024

Job #1885: Bundle Size — 10.56MiB (~+0.01%).

e77562b(current) vs c9f2a4e main#1884(baseline)

Warning

Bundle contains 2 duplicate packages – View duplicate packages

Bundle metrics  Change 1 change
                 Current
Job #1885		      Baseline
Job #1884
No change  Initial JS 1.86MiB 1.86MiB
No change  Initial CSS 607.87KiB 607.87KiB
Change  Cache Invalidation 18.3% 17.63%
No change  Chunks 223 223
No change  Assets 246 246
No change  Modules 2861 2861
No change  Duplicate Modules 141 141
No change  Duplicate Code 1.73% 1.73%
No change  Packages 95 95
No change  Duplicate Packages 2 2
Bundle size by type  Change 1 change Regression 1 regression
                 Current
Job #1885		      Baseline
Job #1884
Regression  JS 8.75MiB (~+0.01%) 8.75MiB
Not changed  CSS 890.07KiB 890.07KiB
Not changed  Fonts 526.1KiB 526.1KiB
Not changed  Media 295.6KiB 295.6KiB
Not changed  IMG 140.74KiB 140.74KiB
Not changed  HTML 1.24KiB 1.24KiB
Not changed  Other 871B 871B

View job #1885 report View florian-h05:things-list-index branch activity View project dashboard

@florian-h05 florian-h05 merged commit 0449e51 into openhab:main Mar 30, 2024
6 checks passed
@florian-h05 florian-h05 deleted the things-list-index branch March 30, 2024 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working main ui Main UI
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@florian-h05