[BasicUI] Adjust user-defined colors to theme for better contrast #2521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Setting disabled:
Setting enabled:
Setting disabled:
Setting enabled:
|
Closes openhab#1780 Colors are those defined by user through the labelcolor, valuecolor and iconcolor parameters. The aim is to provide a good contrast n both themes. For example white in light theme just leads to something not visible. So black is used instead. This behaviour is already implemented in the Android app with the same adjustments. Colors adjusted in light theme: yellow, pink, white, lime, aqua, silver and gold. Colors adjusted in dark theme: maroon, purple, green, navy, blue, black and gold. These color adjustments are controlled by a new Basic UI setting, enabled by default. By disabling it, no adjustment is performed and the old behaviour is restored. Signed-off-by: Laurent Garnier <lg.hc@free.fr>
lolodomo
force-pushed
the
basicui_adjusted_colors
branch
from
eb18092
to
cc4a290
Compare
|
Thank you Kai for your reviews. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1780
Colors are those defined by user through the labelcolor, valuecolor and iconcolor parameters. The aim is to provide a good contrast n both themes. For example white in light theme just leads to something not visible. So black is used instead.
This behaviour is already implemented in the Android app with the same adjustments.
Colors adjusted in light theme: yellow, pink, white, lime, aqua, silver and gold.
Colors adjusted in dark theme: maroon, purple, green, navy, blue, black and gold.
These color adjustments are controlled by a new Basic UI setting, enabled by default. By disabling it, no adjustment is performed and the old behaviour is restored.
Signed-off-by: Laurent Garnier lg.hc@free.fr