[blockly] Adjust persistence blocks to breaking changes #2564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
#1952 Bundle Size — 10.6MiB (+0.03%).Warning Bundle contains 2 duplicate packages – View duplicate packages Bundle metrics
|
| Current #1952 |
Baseline #1949 |
|
|---|---|---|
 Initial JS |
1.86MiB |
1.86MiB |
| Initial CSS |
607.87KiB |
607.87KiB |
 Cache Invalidation |
17.91% |
0% |
| Chunks |
223 |
223 |
| Assets |
246 |
246 |
| Modules |
2876 |
2876 |
| Duplicate Modules |
149 |
149 |
| Duplicate Code |
1.86% |
1.86% |
| Packages |
95 |
95 |
| Duplicate Packages |
2 |
2 |
Bundle size by type 1 change 
1 regression
| Current #1952 |
Baseline #1949 |
|
|---|---|---|
| JS |
8.79MiB (+0.04%) |
8.78MiB |
| CSS |
890.75KiB |
890.75KiB |
| Fonts |
526.1KiB |
526.1KiB |
| Media |
295.6KiB |
295.6KiB |
| IMG |
140.74KiB |
140.74KiB |
| HTML |
1.24KiB |
1.24KiB |
| Other |
871B |
871B |
Bundle analysis report Branch florian-h05:blockly-persistence Project dashboard
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
|
Tested together in a session with @florian-h05 in an online session and looks good to us. This is a BREAKING change that requires all Blockly rules that use persistence blocks to be reopened and saved again. |
stefan-hoehn
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adjusts the persistence blocks for the breaking changes of
org.openhab.core.persistence.extensions.PersistenceExtensions.For NashornJS, see openhab/openhab-core#3736 for the changes.
For GraalJS, see https://next.openhab.org/addons/automation/jsscripting/#itempersistence for the current API docs and openhab/openhab-js#331 for the changes.
In a follow-up PR, Blockly should be extended to make use of the new capabilities provided by the changed return type of variance, deviation, average, sum & delta.