Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix startlevel parameter casing #638

Merged
merged 2 commits into from Dec 14, 2020
Merged

Conversation

ghys
Copy link
Member

@ghys ghys commented Dec 14, 2020

Signed-off-by: Yannick Schaus github@schaus.net

Signed-off-by: Yannick Schaus <github@schaus.net>
@ghys ghys requested a review from a team as a code owner December 14, 2020 09:25
@kaikreuzer
Copy link
Member

Did you see https://github.com/openhab/openhab-core/pull/1923/files#diff-a6a3c1453732714bbb77a8d6d87afcb0de30787cb082f93dc71ebb7310a3e580R14-R35?

Do you actually need to duplicate the information in the UI? If so, it should imho be aligned with what we have in the core description (texts as well as only levels >40).

@ghys
Copy link
Member Author

ghys commented Dec 14, 2020

No - but I did it before you added the options... let me see if I can replace it quickly with the sheet for the module.

Signed-off-by: Yannick Schaus <github@schaus.net>
@ghys ghys merged commit e16bf67 into openhab:master Dec 14, 2020
@ghys
Copy link
Member Author

ghys commented Dec 14, 2020

Okay, that's the last one 💪

@ghys ghys added the bug Something isn't working label Dec 14, 2020
@ghys ghys added this to the 3.0.0.RC1 milestone Dec 14, 2020
@kaikreuzer
Copy link
Member

Awesome, you used every minute before the RC1 merge stop ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants