Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing page check in page-view #958

Merged
merged 1 commit into from Mar 15, 2021
Merged

add missing page check in page-view #958

merged 1 commit into from Mar 15, 2021

Conversation

hubsif
Copy link
Contributor

@hubsif hubsif commented Mar 15, 2021

This fixes a bug raised in the community forums.

I couldn't help it and again did some additional cleanup 😬 :

Having both page and ready for the same seemed confusing somewhat inconsistent in lines like this:

    <f7-tabs v-if="page && pageType === 'tabs' && visibleToCurrentUser" :class="{notready: !ready}">

Additionally, I completely removed the notready css, as it actually only gets rendered when it is ready (v-if="page ...).

minor page-view cleanup

Signed-off-by: Hubert Nusser <hubsif@gmx.de>
@hubsif hubsif requested a review from a team as a code owner March 15, 2021 18:08
@relativeci
Copy link

relativeci bot commented Mar 15, 2021

Job #28: Bundle Size — 10.88MB (~-0.01%).

db4e87c vs 3697e20

Changed metrics (2/8)
Metric Current Baseline
Initial JS 1.59MB(~-0.01%) 1.59MB
Cache Invalidation 14.82% 19.68%
Changed assets by type (1/7)
            Current     Baseline
JS 8.55MB (~-0.01%) 8.55MB

View Job #28 report on app.relative-ci.com

Copy link
Member

@ghys ghys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ghys ghys merged commit b94f625 into openhab:main Mar 15, 2021
@ghys ghys added this to the 3.1 milestone Apr 1, 2021
@ghys ghys added bug Something isn't working main ui Main UI labels Apr 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working main ui Main UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants