Icons don't update on openHAB 2 #145
Assignees
Comments
hazzeh
added a commit
to hazzeh/openhab.android
that referenced
this issue
Apr 24, 2016
When using OpenHAB2, fetch icons from the ESH icon servlet. Refactor so the OpenHABWidget.getIconPath() will behave differently depending on OpenHAB version. Use factory method when creating OpenHABWidgets instead of a constructor. Add testCompile dependency to org.json to be able to stub JSONObject. Fixes openhab#145 Signed-off-by: Hans Hazelius <hans@hazelius.se>
hazzeh
added a commit
to hazzeh/openhab.android
that referenced
this issue
Apr 24, 2016
When using OpenHAB2, fetch icons from the ESH icon servlet. Add an abstract method getIconPath() to OpenHABWidget that will fetch the correct path for the server side icon, it will behave differently depending on OpenHAB version. Use factory method when creating OpenHABWidgets instead of a constructor. Add testCompile dependency to org.json to be able to stub JSONObject. Fixes openhab#145 Signed-off-by: Hans Hazelius <hans@hazelius.se>
hazzeh
added a commit
to hazzeh/openhab.android
that referenced
this issue
Apr 24, 2016
When using OpenHAB2, fetch icons from the ESH icon servlet. Add an abstract method getIconPath() to OpenHABWidget that will fetch the correct path for the server side icon, it will behave differently depending on OpenHAB version. Use factory method when creating OpenHABWidgets instead of a constructor. Add testCompile dependency to org.json to be able to stub JSONObject. Fixes openhab#145 Signed-off-by: Hans Hazelius <hans@hazelius.se>
hazzeh
added a commit
to hazzeh/openhab.android
that referenced
this issue
Apr 24, 2016
When using OpenHAB2, fetch icons from the ESH icon servlet. Add an abstract method getIconPath() to OpenHABWidget that will fetch the correct path for the server side icon, it will behave differently depending on OpenHAB version. Use factory method when creating OpenHABWidgets instead of a constructor. Add testCompile dependency to org.json to be able to stub JSONObject. Fixes openhab#145 Signed-off-by: Hans Hazelius <hans@hazelius.se>
hazzeh
added a commit
to hazzeh/openhab.android
that referenced
this issue
Apr 24, 2016
When using OpenHAB2, fetch icons from the ESH icon servlet. Add an abstract method getIconPath() to OpenHABWidget and OpenHABSitemap that will fetch the correct path for the server side icon, it will behave differently depending on OpenHAB version. Use factory method when creating OpenHABWidgets instead of a constructor. Add testCompile dependency to org.json to be able to stub JSONObject. Fixes openhab#145 Signed-off-by: Hans Hazelius <hans@hazelius.se>
digitaldan
pushed a commit
that referenced
this issue
Apr 25, 2016
When using OpenHAB2, fetch icons from the ESH icon servlet. Add an abstract method getIconPath() to OpenHABWidget and OpenHABSitemap that will fetch the correct path for the server side icon, it will behave differently depending on OpenHAB version. Use factory method when creating OpenHABWidgets instead of a constructor. Add testCompile dependency to org.json to be able to stub JSONObject. Fixes #145 Signed-off-by: Hans Hazelius <hans@hazelius.se>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The app still expects a string like "rollershutter-40" as an icon parameter in the sitemap.
In openHAB 2, this has been split into icon and state now - so you only receive "rollershutter" as the icon and you will have "40" as the state.
From this, the HTTP request has to be assembled like in the past as 'icon/rollershutter-40.png' or alternatively (recommended!) as 'icon/rollershutter?state=40&format=png'.
See https://www.eclipse.org/smarthome/documentation/features/ui/icons.html#icon-servlet for details.
The text was updated successfully, but these errors were encountered: