Denon binding #1910

idserda · 2014-12-30T18:52:36Z

Denon binding, still work in progress

Wiki page

TODO:

~~Support more commands (set surround mode, etc.)~~
~~Support more 'value' properties (audio/video info, if possible)~~
~~EPL headers~~
~~Javadoc~~

buildhive · 2014-12-30T22:24:23Z

openhab » openhab #1939 SUCCESS
This pull request looks good
(what's this?)

buildhive · 2014-12-31T19:15:37Z

openhab » openhab #1950 SUCCESS
This pull request looks good
(what's this?)

teichsta · 2015-01-01T19:13:30Z

Thanks @idserda, thanks for sharing this Binding. Please let us know if you are ready for Review. Best, Thomas E.-E.

buildhive · 2015-01-06T20:58:31Z

openhab » openhab #2008 FAILURE
Looks like there's a problem with this pull request
(what's this?)

buildhive · 2015-01-06T21:26:37Z

openhab » openhab #2009 FAILURE
Looks like there's a problem with this pull request
(what's this?)

buildhive · 2015-01-07T09:20:39Z

openhab » openhab #2013 SUCCESS
This pull request looks good
(what's this?)

buildhive · 2015-01-10T15:40:11Z

openhab » openhab #2039 SUCCESS
This pull request looks good
(what's this?)

buildhive · 2015-01-17T09:32:25Z

openhab » openhab #2106 FAILURE
Looks like there's a problem with this pull request
(what's this?)

buildhive · 2015-01-18T16:10:53Z

openhab » openhab #2121 SUCCESS
This pull request looks good
(what's this?)

buildhive · 2015-01-19T17:39:48Z

openhab » openhab #2126 FAILURE
Looks like there's a problem with this pull request
(what's this?)

buildhive · 2015-01-19T19:22:29Z

openhab » openhab #2128 FAILURE
Looks like there's a problem with this pull request
(what's this?)

buildhive · 2015-01-19T22:23:07Z

openhab » openhab #2131 FAILURE
Looks like there's a problem with this pull request
(what's this?)

buildhive · 2015-01-20T17:47:19Z

openhab » openhab #2136 SUCCESS
This pull request looks good
(what's this?)

buildhive · 2015-01-24T11:54:46Z

openhab » openhab #2160 SUCCESS
This pull request looks good
(what's this?)

teichsta · 2015-03-27T23:14:58Z

Any news @idserda? Is this Binding ready for review? Best, Thomas E.-E.

idserda · 2015-04-13T19:25:57Z

@teichsta, this binding is now ready for review!

buildhive · 2015-04-13T22:51:12Z

openhab » openhab #2761 SUCCESS
This pull request looks good
(what's this?)

buildhive · 2015-04-14T00:06:03Z

openhab » openhab #2762 SUCCESS
This pull request looks good
(what's this?)

buildhive · 2015-04-14T01:19:59Z

openhab » openhab #2763 SUCCESS
This pull request looks good
(what's this?)

teichsta · 2015-04-29T16:42:46Z

...org.openhab.binding.denon/src/main/java/org/openhab/binding/denon/internal/DenonBinding.java

+		{	
+			DenonBindingConfig config = ((DenonBindingProvider) provider).getConfig(itemName);
+			if (config != null) {
+				connections.get(config.getInstance()).getConnector().updateStateFromCache(config.getProperty());


since the phrase connections.get(config.getInstance()).getConnector() is duplicated a lot it might be worth refactoring it into a new method?

teichsta · 2015-04-30T11:33:45Z

...g.openhab.binding.denon/src/main/java/org/openhab/binding/denon/internal/DenonConnector.java

+	}
+
+	private String toDenonValue(BigDecimal percent) {
+		BigDecimal round = new BigDecimal("0.5");


extract 0.5 as a final static member constant

teichsta · 2015-04-30T11:53:55Z

Hi @idserda, please find my review comments inline. Thanks, Thomas E.-E.

teichsta · 2015-05-04T16:56:00Z

any chance to get the feedback incorporated soon?

idserda · 2015-05-04T17:15:39Z

Yes, almost ready. I'll probably push the changes tomorrow morning.

idserda · 2015-05-05T08:31:57Z

@teichsta Done, thanks for the feedback.

buildhive · 2015-05-05T10:07:20Z

openhab » openhab #2900 SUCCESS
This pull request looks good
(what's this?)

buildhive · 2015-05-05T11:29:15Z

openhab » openhab #2901 SUCCESS
This pull request looks good
(what's this?)

buildhive · 2015-05-06T20:58:28Z

openhab » openhab #2908 SUCCESS
This pull request looks good
(what's this?)

buildhive · 2015-05-06T23:06:40Z

openhab » openhab #2909 SUCCESS
This pull request looks good
(what's this?)

teichsta · 2015-05-12T20:36:46Z

Thanks again @idserda. Could you please also link to the according Wiki page here? Best, Thomas E.-E.

Ma-580 mentioned this pull request Jan 1, 2015

Denon AV Receiver - IP Control #510

Closed

teichsta added awaiting-feedback enhancement labels Jan 1, 2015

teichsta added this to the 1.7.0 milestone Jan 1, 2015

teichsta added new-binding-action-service and removed enhancement labels Jan 7, 2015

teichsta added the on-hold label Mar 27, 2015

teichsta removed awaiting-feedback on-hold labels Apr 17, 2015

teichsta reviewed Apr 29, 2015
View reviewed changes

teichsta reviewed Apr 30, 2015
View reviewed changes

teichsta added the awaiting-feedback label Apr 30, 2015

teichsta assigned idserda May 4, 2015

teichsta removed the awaiting-feedback label May 4, 2015

Denon binding

d9483b1

teichsta assigned teichsta and unassigned idserda May 12, 2015

teichsta merged commit d9483b1 into openhab:master May 12, 2015

teichsta assigned idserda and unassigned teichsta May 12, 2015

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Denon binding #1910

Denon binding #1910

idserda commented Dec 30, 2014

buildhive commented Dec 30, 2014

buildhive commented Dec 31, 2014

teichsta commented Jan 1, 2015

buildhive commented Jan 6, 2015

buildhive commented Jan 6, 2015

buildhive commented Jan 7, 2015

buildhive commented Jan 10, 2015

buildhive commented Jan 17, 2015

buildhive commented Jan 18, 2015

buildhive commented Jan 19, 2015

buildhive commented Jan 19, 2015

buildhive commented Jan 19, 2015

buildhive commented Jan 20, 2015

buildhive commented Jan 24, 2015

teichsta commented Mar 27, 2015

idserda commented Apr 13, 2015

buildhive commented Apr 13, 2015

buildhive commented Apr 14, 2015

buildhive commented Apr 14, 2015

teichsta Apr 29, 2015

teichsta Apr 30, 2015

teichsta commented Apr 30, 2015

teichsta commented May 4, 2015

idserda commented May 4, 2015

idserda commented May 5, 2015

buildhive commented May 5, 2015

buildhive commented May 5, 2015

buildhive commented May 6, 2015

buildhive commented May 6, 2015

teichsta commented May 12, 2015

Denon binding #1910

Denon binding #1910

Conversation

idserda commented Dec 30, 2014

buildhive commented Dec 30, 2014

buildhive commented Dec 31, 2014

teichsta commented Jan 1, 2015

buildhive commented Jan 6, 2015

buildhive commented Jan 6, 2015

buildhive commented Jan 7, 2015

buildhive commented Jan 10, 2015

buildhive commented Jan 17, 2015

buildhive commented Jan 18, 2015

buildhive commented Jan 19, 2015

buildhive commented Jan 19, 2015

buildhive commented Jan 19, 2015

buildhive commented Jan 20, 2015

buildhive commented Jan 24, 2015

teichsta commented Mar 27, 2015

idserda commented Apr 13, 2015

buildhive commented Apr 13, 2015

buildhive commented Apr 14, 2015

buildhive commented Apr 14, 2015

teichsta Apr 29, 2015

Choose a reason for hiding this comment

teichsta Apr 30, 2015

Choose a reason for hiding this comment

teichsta commented Apr 30, 2015

teichsta commented May 4, 2015

idserda commented May 4, 2015

idserda commented May 5, 2015

buildhive commented May 5, 2015

buildhive commented May 5, 2015

buildhive commented May 6, 2015

buildhive commented May 6, 2015

teichsta commented May 12, 2015