Skip to content
This repository has been archived by the owner on May 17, 2021. It is now read-only.

code cleanup, remove skeleton Action from Prowl that does nothing #2548

Merged
merged 1 commit into from
May 12, 2015

Conversation

mstolt
Copy link
Contributor

@mstolt mstolt commented May 5, 2015

During looking around who to implement Actions i stumbled across a method remaining from the skeleton build. I think it can be deleted.

@teichsta Is it ok for you to do pull request for such small cleanups or do you prefer to have a bigger pull request with a collection of them? I am just asking, to fit better into your way of development.

@mstolt mstolt changed the title code cleanup, remove skeleton Action that does nothing from the code code cleanup, remove skeleton Action from Prowl that does nothing May 5, 2015
@mstolt
Copy link
Contributor Author

mstolt commented May 5, 2015

I just check the other action addons for exceed skeleton methods and found none.

@buildhive
Copy link

openhab » openhab #2899 SUCCESS
This pull request looks good
(what's this?)

@teichsta teichsta added this to the 1.7.0 milestone May 12, 2015
@teichsta
Copy link
Member

@teichsta Is it ok for you to do pull request for such small cleanups or do you prefer to have a bigger pull request with a collection of them? I am just asking, to fit better into your way of development.

i am absolutely fine with this granularity! Thanks @mstolt!

teichsta added a commit that referenced this pull request May 12, 2015
code cleanup, remove skeleton Action from Prowl that does nothing
@teichsta teichsta merged commit 9cf040a into openhab:master May 12, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants