Skip to content
This repository has been archived by the owner on May 17, 2021. It is now read-only.

Netatmo: Fix for defect #3891 and #3995 #3964

Merged
merged 1 commit into from Feb 9, 2016
Merged

Netatmo: Fix for defect #3891 and #3995 #3964

merged 1 commit into from Feb 9, 2016

Conversation

robnielsen
Copy link
Contributor

This is a fix the defects:

#3891, Netatmo sends back lower case device and module id's.
#3995, The binding was reporting different wifi and rf values than Netatmo is reporting.

@robnielsen
Copy link
Contributor Author

@clinique, don't know if this can happen with the OH2 version of the Netatmo binding or not.

@clinique
Copy link
Contributor

clinique commented Feb 3, 2016

@robnielsen : great chances that we'd face the same behaviour on v2. This may not appear with the auto-discovery but for users declared devices and modules.

@robnielsen robnielsen changed the title Netatmo: Fix for defect #3891. Netatmo sends back lower case device and module id's. Netatmo: Fix for defect #3891 and #3995 Feb 7, 2016
@robnielsen
Copy link
Contributor Author

@lolodomo can you please review my changes?

@lolodomo
Copy link
Contributor

lolodomo commented Feb 7, 2016

@robnielsen
New code for RF status and WiFi signal looks good except at line 568 where I would have used <= rather than <

For #3891, Netatmo sends back lower case device and module id's.
For #3995, The binding was reporting different wifi and rf values than Netatmo is reporting.
@robnielsen
Copy link
Contributor Author

Thanks @lolodomo for catching the < vs <=. I fixed it and squashed the commit.

@teichsta teichsta added the bug label Feb 9, 2016
@teichsta teichsta added this to the 1.8.2 milestone Feb 9, 2016
teichsta added a commit that referenced this pull request Feb 9, 2016
@teichsta teichsta merged commit 11aa0ee into openhab:master Feb 9, 2016
@teichsta teichsta modified the milestones: 1.9.0, 1.8.2 Feb 9, 2016
@teichsta
Copy link
Member

teichsta commented Feb 9, 2016

@clinique will you take care of double checking this issue against the OH2 binding, please?

@clinique
Copy link
Contributor

Sure - doing right now - and yes, confirmed. v2 of the driver is subject to #3891 also.

@lolodomo
Copy link
Contributor

Please include this patch in 1.8.2.

@robnielsen
Copy link
Contributor Author

@teichsta, do you want this merged to the 1.8 branch? If so it will need a new PR due to changes for the Welcome camera. I'll also include #4016 and #4028 since they are pretty much all related.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants