This repository has been archived by the owner on May 17, 2021. It is now read-only.
Netatmo: Fix for defect #4015, added support for BatteryStatus and new BatteryPercentage parameter #4016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added support for BatteryStatus, which is similar to WifiStatus and RfStatus. Added parameter BatteryPercentage which provides the same value as Batteryvp, but is more descriptive of what the parameter actually is used for.
| case BATTERYVP: | ||
| case RFSTATUS: | ||
| for (Device device : stationsDataResponse.getDevices()) { | ||
| for (Module module : device.getModules()) { | ||
| if (module.getId().equals(moduleId)) { | ||
| switch (measureType) { | ||
| case BATTERYPERCENT: | ||
| case BATTERYVP: |
There was a problem hiding this comment.
Does this mean that binding users can't retrieve the battery_vp value because it's returned as a percentage instead of its actual value? Otherwise the pr lgtm.
There was a problem hiding this comment.
yes that is correct. This is from the Netatmo documentation:
Number Netatmo_Outdoor_Batteryvp "Outdoor battery status [%d %%]" (Netatmo {netatmo="00:00:00:00:00:00#02:00:00:00:00:00#Batteryvp"}
There was a problem hiding this comment.
Thanks Rob. Well a percentage is probably a little more useful anyway....
teichsta
added a commit
that referenced
this pull request
Feb 11, 2016
Netatmo: Fix for defect #4015, added support for BatteryStatus and new BatteryPercentage parameter
|
Thanks guys! |
|
Please include this patch in 1.8.2. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix defect #4015, battery percentages are wrong.
Added support for BatteryStatus, which is similar to WifiStatus and RfStatus.
Added parameter BatteryPercentage which provides the same value as Batteryvp, but is more descriptive of what the parameter actually is used for.