Skip to content
This repository has been archived by the owner on May 17, 2021. It is now read-only.

Add missing Insteon device catagories #1560

Closed
wants to merge 2 commits into from

Conversation

LiberatorUSA
Copy link

The 2 devices added are devices I have in my home. I added these to get my home Insteon network fully working.

@buildhive
Copy link

openhab » openhab #1411 SUCCESS
This pull request looks good
(what's this?)

@berndpfrommer
Copy link
Contributor

Thanks for adding these devices!
Unfortunately, there is a conflicting pull request #1542 where I have changed the file format for new devices. It is much simpler now, see updated wiki.
Can this wait until #1542 has been approved, and then resubmitted against the new code base?
If it's too much hassle for you I'll merge them in and submit a new pull request to add the devices. Let me know.

@teichsta
Copy link
Member

teichsta commented Nov 5, 2014

#1542 has been merged now. @LiberatorUSA could you please update the xml description accordingly? Thanks in advance, Thomas E.-E.

@teichsta teichsta added this to the 1.6.0 milestone Nov 5, 2014
@teichsta
Copy link
Member

@LiberatorUSA it would be great to have your changes merged to the main repo. Could you help merging your content into the changed xml structure? Best, Thomas E.-E.

@berndpfrommer
Copy link
Contributor

In absence of response from @LiberatorUSA I will add the devices to the new source tree and submit a new pull request. We definitely want to have these devices in the tree!

@berndpfrommer
Copy link
Contributor

The changes have been refiled under pull request #1646.
This pull request can now be closed.

@teichsta
Copy link
Member

merged #1646 close this PR hence … thanks @berndpfrommer

@teichsta teichsta closed this Nov 11, 2014
@teichsta teichsta removed this from the 1.6.0 milestone Nov 11, 2014
@LiberatorUSA
Copy link
Author

All my github emails were going to spam so I never saw these comments I'm afraid.
I rarely have any time anyway so probably would not have had time to reintegrate it.

Thanks for merging this @berndpfrommer!!!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants