Skip to content
This repository has been archived by the owner on May 17, 2021. It is now read-only.

new binding for picnet home automation devices #3050

Closed
wants to merge 87 commits into from

Conversation

paolodenti
Copy link
Contributor

Hi,
i am just submitting a new binding for picnet home automation devices

I just left the binding project, the modified pom.xml and the default configuration

Thanks
Paolo

@paolodenti
Copy link
Contributor Author

we have some further developments on another branch (rollershutter and dimmer added).
As the pull request has not yet been executed can i merge those changes in the meanwhile?

@teichsta
Copy link
Member

can i merge those changes in the meanwhile?

yes, please :-) (i saw you did it meanwhile). Btw: for this initial contribution if won't be too relevant but it's definitely good practice to add comprehensive commit messages. It would be great if you could add more meaningful messages for future enhancements :-)

@paolodenti
Copy link
Contributor Author

Thanks teichsta. we will do it for sure. As you point out, we are just in the first development version. For future fixes and add on, commit messages will be meaningful.

@paolodenti
Copy link
Contributor Author

how should we proceed about the binding documentation in the wiki?
Should i wait for pull request completion before adding the documentation?
And how do i modify the wiki adding our binding markdown?

@watou
Copy link
Contributor

watou commented Sep 2, 2015

You can create a new page in the wiki by going here. Look at other pages for bindings as examples, and press the Edit button on one in order to see the markdown formatting its author(s) used (but don't save). When you are ready to share the documentation (i.e., you know the release it will appear in), simply edit the sidebar and carefully add your binding to the list at the correct point. Make note in your wiki page of what release it will first appear in.

@paolodenti
Copy link
Contributor Author

@teichsta do you have any forecast about pull request execution? Thanks

@wtrucci
Copy link

wtrucci commented Oct 2, 2015

Tested on production and all works fine. I hope this binding will be included as soon is possible :-)

@paolodenti
Copy link
Contributor Author

Substituted by #3229 (using a dedicated branch instead of master)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants